From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 42A981F852 for ; Thu, 20 Jan 2022 22:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243835AbiATWds (ORCPT ); Thu, 20 Jan 2022 17:33:48 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56850 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234313AbiATWdn (ORCPT ); Thu, 20 Jan 2022 17:33:43 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id D774817C58D; Thu, 20 Jan 2022 17:33:42 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=+ONVSsa2OBGYJknvYSuIs1PhsWHEShHQ9VB9C0 fjYKA=; b=PL4iOZuGi0I0ZxIl8SNh0LgFEHnRvK4iemqMbVvJfVIFwfIq6uMDNj R5tp2w3RwEmd+6J50ycC45Thab0EXsbduyg21yqvga9ryXOQc7FZ4yQcN4hxpilx 5LTHX9XlPj2vh0JC4PUpTMHxGeZvj0j1FhziQ645uM6BXCgvN2D+g= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id CFC1D17C58C; Thu, 20 Jan 2022 17:33:42 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 45D0E17C58A; Thu, 20 Jan 2022 17:33:40 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Todd Zullinger , Petr =?utf-8?B?xaBwbMOtY2hhbA==?= Subject: Re: [PATCH] checkout: fix BUG() case in 9081a421a6 References: Date: Thu, 20 Jan 2022 14:33:39 -0800 In-Reply-To: (Junio C. Hamano's message of "Thu, 20 Jan 2022 14:29:51 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 042AE772-7A41-11EC-AAA8-C85A9F429DF0-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > So from my point of view, BUG() is indeed inappropriate because what > the conditional statement noticed was a broken repository, and not a > programming bug. Forgot to say: "; it should have been at least a warning(), if not a die()".