From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E515B1F54E for ; Thu, 18 Aug 2022 21:32:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="L4QG6QZD"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345023AbiHRVbO (ORCPT ); Thu, 18 Aug 2022 17:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345699AbiHRVbI (ORCPT ); Thu, 18 Aug 2022 17:31:08 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60585222 for ; Thu, 18 Aug 2022 14:31:04 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C7DD713B8A7; Thu, 18 Aug 2022 17:31:02 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=p9Bl9/ClY0FnX7X674oxPhySagKcp9JaP1064h jTIm0=; b=L4QG6QZDhpnzCTRb4z7+n9SUlaFv6/mSArgmbhE2ejFHfNFx8M4yX6 OId5xpzKi9smIjYAFZ7o9KXdk6zNc2EMCOvng77KTkmxm8x/6CXyDndzkZYnOLKF emghryZQF1q3Wk9Aroh/WTSVPtGS3rFDiqX4ba2NcPTu7VyOCTo7A= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BD4B913B8A6; Thu, 18 Aug 2022 17:31:02 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 0EB3613B8A4; Thu, 18 Aug 2022 17:31:01 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Christian Couder Cc: Maxwell Bernstein , Max Bernstein via GitGitGadget , git@vger.kernel.org, Max Bernstein , Max Bernstein , Jonathan Tan Subject: Re: [PATCH v2] trailer: allow spaces in tokens References: Date: Thu, 18 Aug 2022 14:31:00 -0700 In-Reply-To: (Christian Couder's message of "Thu, 18 Aug 2022 22:46:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 0ED7AEDE-1F3D-11ED-ADDF-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Christian Couder writes: > I think allowing one white space before the separator is a good idea > for the following reasons. > ... > I think it would be very annoying for users to find out that a number > of otherwise proper trailers would not be taken into account only > because they have a white space before the colon. At least there > should be an option to allow that. In short, you do not support Max's patch that allows arbitrary number of white spaces anywhere but at the beginning of line, but see a room for unrelated improvement from the current code, namely, to allow exactly one optional space, immediately before the separator and nowhere else. It may be a reasonable thing to do that may not break too many things. I do not know if that is loose enough to satisify Max's original wish, though. Thanks.