From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] allow grep -E, and remove egrep
Date: Tue, 20 Sep 2022 10:52:10 -0700 [thread overview]
Message-ID: <xmqqa66u6iid.fsf@gitster.g> (raw)
In-Reply-To: <cover.1663688697.git.congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Tue, 20 Sep 2022 22:49:12 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> Despite our CodingGuidelines dictates that grep -E and or grep \{m,n\}
> are forbidden. Our code bases uses them all over place.
That makes it sounds like rules dictating and coders resisting, but
that is not what is happening.
Portability guidelines need updating as tools on different platforms
change over time. An effort like this series is very much
appreciated from time to time.
prev parent reply other threads:[~2022-09-20 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:49 [PATCH 0/4] allow grep -E, and remove egrep Đoàn Trần Công Danh
2022-09-20 15:49 ` [PATCH 1/4] CodingGuidelines: allow grep -E Đoàn Trần Công Danh
2022-09-20 15:49 ` [PATCH 2/4] t: remove \{m,n\} from BRE grep usage Đoàn Trần Công Danh
2022-09-20 16:43 ` SZEDER Gábor
2022-09-20 17:42 ` Phillip Wood
2022-09-20 17:52 ` Junio C Hamano
2022-09-20 15:49 ` [PATCH 3/4] t: convert egrep usage to "grep -E" Đoàn Trần Công Danh
2022-09-20 15:49 ` [PATCH 4/4] t: convert fgrep usage to "grep -F" Đoàn Trần Công Danh
2022-09-20 17:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa66u6iid.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).