git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] doc: simplify man version
Date: Mon, 10 Apr 2023 16:43:59 -0700	[thread overview]
Message-ID: <xmqqa5zfcngg.fsf@gitster.g> (raw)
In-Reply-To: 20230409190805.GA77061@coredump.intra.peff.net

Jeff King <peff@peff.net> writes:

>> Is this a complete patch, or will this leave us in an incomplete
>> in-between place?
>> 
>> We have some references to manversion in "git grep manversion
>> Documentation/" in asciidoc.conf and asciidoctor-extensions.rb
>> remaining after this ptach is applied, which presumably are no
>> longer used.  I would imagine that these leftover references end up
>> substituting them with something benign, like an empty string, in
>> the output, but it somehow makes me feel dirty [*].
>
> I think we are OK with this patch on its own. Asciidoc seems to be smart
> enough to omit the empty XML element on its own.

OK, that kind of "why is this a safe thing to do" was what I
expected to see explained in the proposed log message.

Will queue.

Thanks, both.

  parent reply	other threads:[~2023-04-10 23:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-08  0:18 [PATCH] doc: simplify man version Felipe Contreras
2023-04-08 22:45 ` Junio C Hamano
2023-04-09 19:08   ` Jeff King
2023-04-10 23:41     ` Felipe Contreras
2023-04-10 23:43     ` Junio C Hamano [this message]
2023-04-10 23:32   ` Felipe Contreras
2023-04-11 16:30     ` Junio C Hamano
2023-04-16  3:45 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5zfcngg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).