From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH v10 1/1] refs.c: SSE2 optimizations for check_refname_component
Date: Tue, 17 Jun 2014 11:03:46 -0700 [thread overview]
Message-ID: <xmqq8uovmn0d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1403025199-21360-2-git-send-email-dturner@twitter.com> (David Turner's message of "Tue, 17 Jun 2014 13:13:19 -0400")
David Turner <dturner@twopensource.com> writes:
> Optimize check_refname_component using SSE2 on x86_64.
>
> git rev-parse HEAD is a good test-case for this, since it does almost
> nothing except parse refs. For one particular repo with about 60k
> refs, almost all packed, the timings are:
>
> Look up table: 29 ms
> SSE2: 23 ms
>
> This cuts about 20% off of the runtime.
>
> Ondřej Bílka <neleai@seznam.cz> suggested an SSE2 approach to the
> substring searches, which netted a speed boost over the SSE4.2 code I
> had initially written.
>
> Signed-off-by: David Turner <dturner@twitter.com>
> ---
When applied on top of your dde8a902 (refs.c: optimize
check_refname_component(), 2014-06-03), this seems to fail t1402 for
me.
Test Summary Report
-------------------
t1402-check-ref-format.sh (Wstat: 256 Tests: 93 Failed: 9)
Failed tests: 28, 36, 38, 40, 63, 75, 77, 85-86
Non-zero exit status: 1
#28 is the one that runs "check-ref-format heads/v@{ation".
next prev parent reply other threads:[~2014-06-17 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 17:13 (unknown), David Turner
2014-06-17 17:13 ` [PATCH v10 1/1] refs.c: SSE2 optimizations for check_refname_component David Turner
2014-06-17 18:03 ` Junio C Hamano [this message]
2014-06-17 18:07 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8uovmn0d.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twitter.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).