git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Olaf Hering <olaf@aepfle.de>, John Keeping <john@keeping.me.uk>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: git log fails to show all changes for a file
Date: Wed, 15 Jul 2015 09:29:25 -0700	[thread overview]
Message-ID: <xmqq8uahxu3e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CA+55aFzPvwAghGtA-WH8i1PcNe55XORokaXF9hNu7OUXBx++6Q@mail.gmail.com> (Linus Torvalds's message of "Tue, 14 Jul 2015 12:16:48 -0700")

Linus Torvalds <torvalds@linux-foundation.org> writes:

> That said, I do wonder if we should just make "-p" imply "--cc". Right
> now we have the kind of odd situation that "git log -p" doesn't show
> merge patches, but "git show <cmit>" does show them. And you kind of
> have to know a lot about git to know the "--cc" option.
>
> In fact, that "git show" behavior really is very subtle, but very
> useful. It comes from show_rev_tweak_rev(), which is a magic git-show
> thing.

I would think "git log -p" that implies "--cc" would be a good
change, as long as there is an easy escape hatch to let us do what
we have to do with a rather lengthy "git log -p --first-parent -m"
(i.e. show the change relative to its first parent while traversing
the first parent chain) today.  Perhaps only when there is no
explicit "-m" but "-p" is given, automatically enable "--cc", or
something like that.

  reply	other threads:[~2015-07-15 16:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  7:30 git log fails to show all changes for a file Olaf Hering
2015-07-14  7:45 ` John Keeping
2015-07-14  7:59   ` Olaf Hering
2015-07-14 17:54     ` Andreas Schwab
2015-07-14 19:16     ` Linus Torvalds
2015-07-15 16:29       ` Junio C Hamano [this message]
2015-07-15 17:13         ` Linus Torvalds
2015-07-15 17:58           ` Junio C Hamano
2015-07-15 18:11             ` Linus Torvalds
2015-07-15 18:17               ` Junio C Hamano
2015-07-15 18:57                 ` Jeff King
2015-07-15 19:22                   ` Junio C Hamano
2015-07-15 19:17                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8uahxu3e.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    --cc=olaf@aepfle.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).