From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Johannes Sixt" <j6t@kdbg.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v2] fix pushing to //server/share/dir on Windows
Date: Thu, 15 Dec 2016 09:49:46 -0800 [thread overview]
Message-ID: <xmqq8trhw091.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161215110155.it7ptkbju5etmnpn@sigill.intra.peff.net> (Jeff King's message of "Thu, 15 Dec 2016 06:01:55 -0500")
Jeff King <peff@peff.net> writes:
> I don't have an opinion either way on what Windows would want, but note
> that the function already _does_ convert separators to slashes. With
> Johannes's original patch, you'd end up with a mix, like:
>
> \\server\share/dir1/file
>
> So this conversion is really just retaining the original behavior, and
> making it consistent throughout the path.
>
> Which isn't to say that the function as it currently exists isn't a
> little bit buggy. :)
>
> One of the points of normalizing, though, is that Git can then do
> textual comparisons between the output. So I think there's value in
> having a canonical internal representation, even if the OS could handle
> more exotic ones.
E.g. the log message of d53c2c6738 ("mingw: fix t9700's assumption
about directory separators", 2016-01-27) says the two kinds of
slashes are equivalent over there, but the patch text ends up doing
exactly that normalization.
5ca6b7bb47 ("config --show-origin: report paths with forward
slashes", 2016-03-23) is an example of us trying to normalize in
order to give consistent output to the users.
Having said all that, I do not have an opinion either way on what
Windows would want, either ;-)
next prev parent reply other threads:[~2016-12-15 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 21:32 [PATCH] fix pushing to //server/share/dir paths on Windows Johannes Sixt
2016-12-13 22:48 ` Junio C Hamano
2016-12-14 17:30 ` Jeff King
2016-12-14 19:37 ` [PATCH v2] fix pushing to //server/share/dir " Johannes Sixt
2016-12-15 7:30 ` Torsten Bögershausen
2016-12-15 11:01 ` Jeff King
2016-12-15 17:49 ` Junio C Hamano [this message]
2016-12-19 17:18 ` [PATCH] fix pushing to //server/share/dir paths " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8trhw091.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).