From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Johannes Sixt" <j6t@kdbg.org>,
"Ramsay Jones" <ramsay@ramsay1.demon.co.uk>,
"Stefano Lattarini" <stefano.lattarini@gmail.com>,
"Ondřej Bílka" <neleai@seznam.cz>,
"Arnold D . Robbins" <arnold@skeeve.com>
Subject: Re: [PATCH 0/7] Update the compat/regex engine from upstream
Date: Mon, 08 May 2017 09:55:15 +0900 [thread overview]
Message-ID: <xmqq8tm8cglo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170504220043.25702-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 4 May 2017 22:00:36 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> See the first patch for motivation & why.
I do not think it quite explains the motivation, though. "Doing
this way, we can keep in sync with the upstream more easily"? Or is
there anything more to it, e.g. "and we need to update from the
upstream now to fix this and that issues"?
Having these "fixup!" as separate patches on the list makes them
smaller and easier to understand. What do we want to do with them
once they are applied? Squash them all up, because these do not
have their own explanations in their log message and it is not worth
keeping them separate?
> The only reason this has a cover letter is to explain the !fixup
> commits. IIRC the mailing list has a 100K limit, which this series
> would violate, so I split up the second commit.
>
> Consider all these !fixup commits to have by Signed-off-by, easier to
> say that here than to modify them all.
>
> Ævar Arnfjörð Bjarmason (7):
> compat/regex: add a README with a maintenance guide
> compat/regex: update the gawk regex engine from upstream
> fixup! compat/regex: update the gawk regex engine from upstream
> fixup! compat/regex: update the gawk regex engine from upstream
> fixup! compat/regex: update the gawk regex engine from upstream
> fixup! compat/regex: update the gawk regex engine from upstream
> fixup! compat/regex: update the gawk regex engine from upstream
>
> Makefile | 8 +-
> compat/regex/README | 21 +
> compat/regex/intprops.h | 448 +++++++++++++++++++++
> .../0001-Add-notice-at-top-of-copied-files.patch | 120 ++++++
> .../0002-Remove-verify.h-use-from-intprops.h.patch | 41 ++
> compat/regex/regcomp.c | 356 +++++++++-------
> compat/regex/regex.c | 32 +-
> compat/regex/regex.h | 120 +++---
> compat/regex/regex_internal.c | 118 +++---
> compat/regex/regex_internal.h | 118 +++---
> compat/regex/regexec.c | 242 +++++------
> compat/regex/verify.h | 286 +++++++++++++
> 12 files changed, 1487 insertions(+), 423 deletions(-)
> create mode 100644 compat/regex/README
> create mode 100644 compat/regex/intprops.h
> create mode 100644 compat/regex/patches/0001-Add-notice-at-top-of-copied-files.patch
> create mode 100644 compat/regex/patches/0002-Remove-verify.h-use-from-intprops.h.patch
> create mode 100644 compat/regex/verify.h
next prev parent reply other threads:[~2017-05-08 0:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 22:00 [PATCH 0/7] Update the compat/regex engine from upstream Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 1/7] compat/regex: add a README with a maintenance guide Ævar Arnfjörð Bjarmason
2017-05-12 0:47 ` Junio C Hamano
2017-05-12 10:15 ` Johannes Schindelin
2017-05-12 20:59 ` Junio C Hamano
2017-05-14 19:14 ` arnold
2017-05-15 1:20 ` Junio C Hamano
2017-05-15 12:14 ` Johannes Schindelin
2017-05-15 12:51 ` arnold
2017-05-04 22:00 ` [PATCH 2/7] compat/regex: update the gawk regex engine from upstream Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 3/7] fixup! " Ævar Arnfjörð Bjarmason
2017-05-05 5:54 ` Johannes Sixt
2017-05-05 6:12 ` [PATCH v2 8/7] " Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 4/7] " Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 5/7] " Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 6/7] " Ævar Arnfjörð Bjarmason
2017-05-04 22:00 ` [PATCH 7/7] " Ævar Arnfjörð Bjarmason
2017-05-08 0:55 ` Junio C Hamano [this message]
2017-05-08 6:38 ` [PATCH 0/7] Update the compat/regex " Ævar Arnfjörð Bjarmason
2017-05-08 7:03 ` Junio C Hamano
2017-05-12 0:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tm8cglo.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=arnold@skeeve.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=neleai@seznam.cz \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).