From: Junio C Hamano <gitster@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: peff@peff.net, git@vger.kernel.org, kernel-team <kernel-team@fb.com>
Subject: Re: [PATCH v2] name_rev: add support for --cherry-picks
Date: Fri, 27 Jul 2018 08:55:57 -0700 [thread overview]
Message-ID: <xmqq8t5wpt9u.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAOS58YNjyLLDLpoDDB=oAKn3P_FLLD2WZrygBy6J+TV=E480NQ@mail.gmail.com> (Tejun Heo's message of "Fri, 27 Jul 2018 10:47:25 -0400")
Tejun Heo <tj@kernel.org> writes:
> ... After all, calling the program twice isn't all that
> difficult.
As long as we all agree on that, I think we can move forward.
Because I think this ...
>> ... But it feels like
>> "reverse-map the cherry-picks" is orthogonal to the idea of name-rev.
... is a better way of saying what I've been feeling (i.e. the
feature indeed is useful, but does it belong to "name-rev"?), and
none among three of us would mind running "name-rev" to see the
simplest way to reach the primary commit you are interested in from
tags, and another "reverse-map the cherry-picks" command (and in
"git show -s --notes=reverse-cherry-pick" may be that command) to
get the data from that orthogonal feature.
And obviously, "git log --notes=reverse-cherry-pick" would give the
information if we take that "use notes to record reverse map for
cherry-picks" route; adding support for "name-rev --cherry-pick"
would not help such a use case.
prev parent reply other threads:[~2018-07-27 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 12:13 [PATCH] name_rev: add support for --cherry-picks Tejun Heo
2018-07-26 14:39 ` [PATCH v2] " Tejun Heo
2018-07-26 15:12 ` Junio C Hamano
2018-07-26 15:37 ` Tejun Heo
2018-07-26 19:01 ` Junio C Hamano
2018-07-27 8:40 ` Jeff King
2018-07-27 14:47 ` Tejun Heo
2018-07-27 15:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8t5wpt9u.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=peff@peff.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).