mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Julia Lawall <>
Cc: "Ævar Arnfjörð Bjarmason" <>,
	"Git Mailing List" <>
Subject: Re: git log -S or -G
Date: Tue, 09 Oct 2018 08:09:32 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <alpine.DEB.2.21.1810070719200.2347@hadrien> (Julia Lawall's message of "Sun, 7 Oct 2018 07:21:26 +0200 (CEST)")

Julia Lawall <> writes:

>> Doing the same for -S is much harder at the machinery level, as it
>> performs its thing without internally running "diff" twice, but just
>> counts the number of occurrences of 'foo'---that is sufficient for
>> its intended use, and more efficient.
> There is still the question of whether the number of occurrences of foo
> decreases or increases.

Hmph, taking the changes that makes the number of hits decrease
would catch a subset of "changes that removes 'foo' only---I am not
interested in the ones that adds 'foo'".  It will avoid getting
confused by a change that moves an existing 'foo' to another place
in the same file (as the number of hits does not change), but at the
same time, it will miss a change that genuinely removes an existing
'foo' and happens to add a 'foo' at a different place in the same
file that is unrelated to the original 'foo'.  Depending on the
definition of "I am only interested in removed ones", that may or
may not be acceptable.

  reply	other threads:[~2018-10-08 23:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06 15:14 git log -S or -G Julia Lawall
2018-10-06 16:22 ` Ævar Arnfjörð Bjarmason
2018-10-07  0:48   ` Junio C Hamano
2018-10-07  5:21     ` Julia Lawall
2018-10-08 23:09       ` Junio C Hamano [this message]
2018-10-09  3:21         ` Jeff King
2018-10-09  3:58           ` Jacob Keller
2018-10-09  6:39             ` Julia Lawall
2018-10-09  5:21           ` Junio C Hamano
2018-10-09 12:45             ` Ævar Arnfjörð Bjarmason
2018-10-09 13:51               ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).