mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Ramsay Jones <>
Cc: Jeff King <>,
Subject: Re: [PATCH/RFC] Makefile: dedup list of files obtained from ls-files
Date: Tue, 23 Apr 2019 10:18:49 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Ramsay Jones's message of "Mon, 22 Apr 2019 18:15:34 +0100")

Ramsay Jones <> writes:

>> FWIW, after reading your commit message my thoughts immediately turned
>> to "why can't ls-files have a mode that outputs each just once", but
>> then ended up at the same place as your patch: it's not that hard to
>> just de-dup the output.
> My immediate thought was "that is simply a bug, no?" :-D
> I haven't used 'git ls-files' that much, so it's no great surprise
> that I had not noticed it odd behaviour!

Yup, the real issue is that ls-files uses exactly the same code for
tagged output, output with stage numbers and just plain list of
paths, so as we saw in the motivating use case for this patch,
unmerged paths give us one source of duplication when we are asking
for list of paths without stages.

It also considers, IIRC, deletion is merely one of the forms of
modifications, so asking it to list modified paths and deleted paths
at the same time would give you another source of duplication.

Perhaps not-so-low-hanging fruit miniproject would be to teach
"ls-files" a new "--dedup" option that does two things:

 * When -m and -d are asked at the same time, ignore '-d', because
   '-d' will give duplicates for subsets of what '-m' would show
   anyway; and

 * When neither -s nor -u is given, do not show the same path more
   than once, even the ones with multiple stages.

Perhaps it is safe to leave a #leftoverbits mark for the above, now
that two people in addition to I noticed that the behaviour is less
than ideal.

  reply	other threads:[~2019-04-23  1:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21 13:19 [PATCH/RFC] Makefile: dedup list of files obtained from ls-files Junio C Hamano
2019-04-22  3:23 ` Eric Sunshine
2019-04-22  6:11   ` Junio C Hamano
2019-04-22 14:49 ` Jeff King
2019-04-22 17:15   ` Ramsay Jones
2019-04-23  1:18     ` Junio C Hamano [this message]
2019-04-23 20:21   ` SZEDER Gábor
2019-04-24  1:03     ` Junio C Hamano
2019-04-24 11:25       ` SZEDER Gábor
2019-04-24 17:19         ` Eric Sunshine
2019-04-25  0:59           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).