From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Adam Roben" <aroben@apple.com>,
"Bryan Larsen" <bryan.larsen@gmail.com>,
"Matthias Urlichs" <smurf@smurf.noris.de>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 2/3] hash-object doc: elaborate on -w and --literally promises
Date: Tue, 28 May 2019 09:56:19 -0700 [thread overview]
Message-ID: <xmqq8suq4ix8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <86woigp3ro.fsf@gmail.com> (Jakub Narebski's message of "Fri, 24 May 2019 12:04:27 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> I thik that this implemetation detail of `--literally` is here to stay;
> how would you otherwise fix the issue if garbage object makes Git crash?
By repacking, presumably ;-).
More importantly, there needs a way to extend "enum object_type" to
allow unbounded number of arbitrary (garbage) types before we can
allow --literally to record such a garbage type in a pack stream.
So I'd expect the implementation detail would stay for a long time.
But there is nothing that says `--literally` inherently must write
loose. It is plausible that a new implementation writes objects of
known/valid types to a pack stream, while unknown/garbage types to
loose objects.
> However, I would prefer to have options state _intent_; if there is
> legitimate need for a tool that creates loose objects, it would be
> better to have separate `--loose` option to `git hash-object` (which
> would imply `-w`, otherwise it doesn't have sense).
Yes, I very much agree with that.
next prev parent reply other threads:[~2019-05-28 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 21:53 [PATCH 0/3] hash-object doc: small fixes Ævar Arnfjörð Bjarmason
2019-05-20 21:53 ` [PATCH 1/3] hash-object doc: stop mentioning git-cvsimport Ævar Arnfjörð Bjarmason
2019-05-22 4:57 ` Jeff King
2019-05-20 21:53 ` [PATCH 2/3] hash-object doc: elaborate on -w and --literally promises Ævar Arnfjörð Bjarmason
2019-05-22 5:08 ` Jeff King
2019-05-24 10:04 ` Jakub Narebski
2019-05-24 10:12 ` Ævar Arnfjörð Bjarmason
2019-05-28 6:06 ` Jeff King
2019-05-28 16:56 ` Junio C Hamano [this message]
2019-05-28 16:49 ` Junio C Hamano
2019-05-20 21:53 ` [PATCH 3/3] hash-object doc: point to ls-files and rev-parse Ævar Arnfjörð Bjarmason
2019-05-22 5:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8suq4ix8.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=aroben@apple.com \
--cc=avarab@gmail.com \
--cc=bryan.larsen@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
--cc=smurf@smurf.noris.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).