From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Eric Freese <ericdfreese@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] for-each-ref: add '--no-symbolic' option
Date: Sun, 08 Sep 2019 08:40:03 -0700 [thread overview]
Message-ID: <xmqq8sqyn6ek.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190908100543.GB15641@sigill.intra.peff.net> (Jeff King's message of "Sun, 8 Sep 2019 06:05:44 -0400")
Jeff King <peff@peff.net> writes:
> So in my mind there's an endgame we'd like to eventually reach where
> the option added by your patch isn't needed anymore. But we're a long
> way from that. And it's not entirely clear where we'd draw the line
> anyway.
All true and very good "thinking out loud".
> So in the meantime, this seems like a useful thing, and it
> wouldn't be a burden to carry it even if we eventually added
> "--omit=%(symref)" or something.
I would draw the line above this particular change, though.
>> +--no-symbolic::
>> + Only list refs that are not symbolic.
>> +
>
> I wonder if "symbolic" might be too vague here. Would "--no-symref" be a
> better name?
Definitely. Another disturbing thing is the design mistake that
made this a bool. If it is useful to filter out symrefs, it would
equally be useful to only show symrefs. --[no-]symbolic-refs does
not capture the tristate-ness, and that is why I do not think this
is good enough in the meantime, without causing us trouble carrying
forward.
THanks.
next prev parent reply other threads:[~2019-09-08 15:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 21:36 [RFC PATCH 0/1] for-each-ref: Add '--no-symbolic' option Eric Freese
2019-09-07 21:36 ` [RFC PATCH 1/1] for-each-ref: add " Eric Freese
2019-09-07 23:28 ` Taylor Blau
2019-09-07 23:39 ` Taylor Blau
2019-09-08 9:44 ` Jeff King
2019-09-07 23:37 ` Taylor Blau
2019-09-08 10:05 ` Jeff King
2019-09-08 15:40 ` Junio C Hamano [this message]
2019-09-08 22:34 ` Junio C Hamano
2019-09-09 4:01 ` Eric Freese
2019-09-09 12:57 ` Jeff King
2019-09-09 18:08 ` Junio C Hamano
2019-09-07 23:16 ` [RFC PATCH 0/1] for-each-ref: Add " Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8sqyn6ek.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=ericdfreese@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).