From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EF1001F463 for ; Mon, 16 Dec 2019 20:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfLPUjK (ORCPT ); Mon, 16 Dec 2019 15:39:10 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:60553 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfLPUjK (ORCPT ); Mon, 16 Dec 2019 15:39:10 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 34D8633134; Mon, 16 Dec 2019 15:39:08 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=pm2BjrbwCdxtYI1riaQmOWn2GwM=; b=mh0ran MlGwy5TGXj5BE/UXoL7RarIkQ+YSprBRnJX60uFc1Rcoalw7Y4791Vsvw7qhmV1N ZJeRrbJu7q6MoXBGIQAzZnej8aSiiLOZ/4dutNJGxVBCJVfq3JdaM5TSjPnYX4KU 6M7y+G/u+IQ7pUaVHKobUi3ZQoRGAFjIuBK0I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=l/kZbCVD5ZpQf+wnmvbibjKGH94C823o er7WJmVRksIDnmNxi+Isvxiq4zM4STU23bqJaYMuPphikXj3PatNb/GzkLzfHLM1 V1ekhoQJZTuUyiYeUFhJCF9Su1R+6B/AXr6Nvi3jJNPg00LPdCqMh9GGnvC1Ohql MwJY+8SdEEU= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 2D10B33133; Mon, 16 Dec 2019 15:39:08 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 75DEB33132; Mon, 16 Dec 2019 15:39:07 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Luke Diamand Cc: git@vger.kernel.org, Ben Keene , "Ben Keene via GitGitGadget" Subject: Re: [PATCH v5 0/4] git-p4: Usability enhancements References: Date: Mon, 16 Dec 2019 12:39:06 -0800 In-Reply-To: (Ben Keene via GitGitGadget's message of "Mon, 16 Dec 2019 14:02:18 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 1B3BE348-2044-11EA-8975-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Ben Keene via GitGitGadget" writes: > Some user interaction with git-p4 is not as user-friendly as the rest of the > ... > > Ben Keene (4): > git-p4: yes/no prompts should sanitize user text > git-p4: show detailed help when parsing options fail > git-p4: wrap patchRCSKeywords test to revert changes on failure > git-p4: failure because of RCS keywords should show help The reviews on the list seem to be in favor of these and I didn't see much wrong (I think I fixed up an indented empty line) in the series. I'd appreciate a blessing from a git-p4 expert, though. Thanks.