From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] GIT-VERSION-GEN: update for the post 2.27 cycle
Date: Thu, 11 Jun 2020 12:41:56 -0700 [thread overview]
Message-ID: <xmqq8sgtjsor.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <4946cf3650b95191455630f85f59e5f93156d0ac.1591883410.git.liu.denton@gmail.com> (Denton Liu's message of "Thu, 11 Jun 2020 09:50:20 -0400")
Denton Liu <liu.denton@gmail.com> writes:
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> GIT-VERSION-GEN | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index 06a5333ee6..7b0cfeb92e 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -1,7 +1,7 @@
> #!/bin/sh
>
> GVF=GIT-VERSION-FILE
> -DEF_VER=v2.27.0
> +DEF_VER=v2.27.GIT
I have been thinking about stopping this transition from ".0" to
".GIT" and left it at ".0" deliberately.
- The target to create a tarball ("make dist") places the "version"
file that overrides whatever value is set here, so those who
build from a tarball will not care what the value described here
is.
- Those who build from a repository would use "git describe".
- In addition, I do not create tarballs and upload to public places
for a random version with .GIT suffix---I only do so for -rcX and
the releases. If anybody else is doing so with "make dist",
there would be the "version" file included in the tarball,
recording what is obtained from "git describe HEAD".
So there is no strong reason to care what this value is, and that
was why I was experimenting with the idea of leaving it at ".0",
in the hope of hearing from people who do want to see ".GIT" why
they want it.
Unfortunately, your patch does not say why, either, so it hasn't
quite helped yet ;-)
next prev parent reply other threads:[~2020-06-11 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 13:50 [PATCH] GIT-VERSION-GEN: update for the post 2.27 cycle Denton Liu
2020-06-11 19:41 ` Junio C Hamano [this message]
2020-06-12 0:52 ` Denton Liu
2020-06-12 23:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8sgtjsor.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).