From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Git Mailing List" <git@vger.kernel.org>,
"Derrick Stolee" <dstolee@microsoft.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] revision: reallocate TOPO_WALK object flags
Date: Wed, 24 Jun 2020 09:06:28 -0700 [thread overview]
Message-ID: <xmqq8sgc8n3v.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <8e5b6b9f-a778-7b20-2c67-2d5d8ff0d8a0@gmail.com> (Derrick Stolee's message of "Wed, 24 Jun 2020 09:51:01 -0400")
Derrick Stolee <stolee@gmail.com> writes:
>> @@ -79,7 +79,7 @@ struct object_array {
>> * builtin/show-branch.c: 0-------------------------------------------26
>
> The only collision is here in builtin/show-branch.c, and when I added
> the TOPO_WALK_* bits, I didn't understand that these bits were
> sufficiently independent from the topo-walk logic that we could add
> collisions here.
The show-branch subcommand does its own walking without using any of
the usual revision machinery, and uses a bit per starting point (so
the number of starting points is limited by the wordsize), so it
should be safe.
It would be wonderful if the bits used by it can be moved to a slab
so that it can work from more starting points, or deprecate the
subcommand altogether. With better visualization tools (including
"log --graph --oneline"), I suspect that it outlived its usefulness.
next prev parent reply other threads:[~2020-06-24 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:05 [PATCH] revision: reallocate TOPO_WALK object flags René Scharfe
2020-06-24 13:51 ` Derrick Stolee
2020-06-24 16:06 ` Junio C Hamano [this message]
2020-06-24 19:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8sgc8n3v.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).