From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v5 0/3] Add support for %(contents:size) in ref-filter
Date: Thu, 16 Jul 2020 10:48:58 -0700 [thread overview]
Message-ID: <xmqq8sfjgxkl.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200716121940.21041-1-chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 16 Jul 2020 14:19:37 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> The range diff is:
>
> 1: f750832fc7 = 1: f750832fc7 Documentation: clarify %(contents:XXXX) doc
> 2: 51c72e09d2 = 2: 51c72e09d2 t6300: test refs pointing to tree and blob
> 3: c2ed3e228b ! 3: cf6a60036e ref-filter: add support for %(contents:size)
> @@ t/t6300-for-each-ref.sh: test_atom() {
> + # Automatically test "contents:size" atom after testing "contents"
> + if test "$2" = "contents"
> + then
> -+ case "$1" in
> -+ refs/tags/signed-*)
> ++ case $(git cat-file -t "$ref") in
> ++ tag)
> + # We cannot use $3 as it expects sanitize_pgp to run
> + expect=$(git cat-file tag $ref | tail -n +6 | wc -c) ;;
> -+ refs/mytrees/* | refs/myblobs/*)
> ++ tree | blob)
> + expect='' ;;
> -+ *)
> ++ commit)
> + expect=$(printf '%s' "$3" | wc -c) ;;
> + esac
> + # Leave $expect unquoted to lose possible leading whitespaces
> + echo $expect >expected
> -+ test_expect_${4:-success} $PREREQ "basic atom: $1 $2:size" "
> -+ git for-each-ref --format='%($2:size)' $ref >actual &&
> -+ test_cmp expected actual
> -+ "
> ++ test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" '
> ++ git for-each-ref --format="%(contents:size)" "$ref" >actual &&
> ++ test_cmp expect actual
> ++ '
> + fi
> }
Ah, I almost forgot about this topic X-<, but the above reminds me
and it does read more clearly, at least to me.
Thanks, will replace.
prev parent reply other threads:[~2020-07-16 17:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 17:40 [PATCH v3 0/4] Add support for %(contents:size) in ref-filter Christian Couder
2020-07-07 17:40 ` [PATCH v3 1/4] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-07 19:26 ` Junio C Hamano
2020-07-10 16:47 ` Christian Couder
2020-07-07 17:40 ` [PATCH v3 2/4] Documentation: clarify 'complete message' Christian Couder
2020-07-07 19:19 ` Junio C Hamano
2020-07-07 17:40 ` [PATCH v3 3/4] t6300: test refs pointing to tree and blob Christian Couder
2020-07-07 19:32 ` Junio C Hamano
2020-07-07 17:40 ` [PATCH v3 4/4] ref-filter: add support for %(contents:size) Christian Couder
2020-07-07 19:45 ` Junio C Hamano
2020-07-09 0:14 ` Junio C Hamano
2020-07-09 8:10 ` Christian Couder
2020-07-09 13:47 ` Junio C Hamano
2020-07-07 22:21 ` Junio C Hamano
2020-07-08 23:05 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 0/3] Add support for %(contents:size) in ref-filter Christian Couder
2020-07-10 16:47 ` [PATCH v4 1/3] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-10 20:24 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 2/3] t6300: test refs pointing to tree and blob Christian Couder
2020-07-10 20:24 ` Junio C Hamano
2020-07-10 16:47 ` [PATCH v4 3/3] ref-filter: add support for %(contents:size) Christian Couder
2020-07-10 20:38 ` Junio C Hamano
2020-07-16 12:19 ` [PATCH v5 0/3] Add support for %(contents:size) in ref-filter Christian Couder
2020-07-16 12:19 ` [PATCH v5 1/3] Documentation: clarify %(contents:XXXX) doc Christian Couder
2020-07-16 12:19 ` [PATCH v5 2/3] t6300: test refs pointing to tree and blob Christian Couder
2020-07-16 12:19 ` [PATCH v5 3/3] ref-filter: add support for %(contents:size) Christian Couder
2020-07-31 17:37 ` Alban Gruin
2020-07-31 17:45 ` [PATCH v1] t6300: fix issues related to %(contents:size) Alban Gruin
2020-07-31 17:47 ` Jeff King
2020-07-31 18:24 ` Alban Gruin
2020-07-31 20:04 ` Junio C Hamano
2020-07-31 20:30 ` Jeff King
2020-07-31 18:26 ` [PATCH v2] " Alban Gruin
2020-07-31 19:15 ` Jeff King
2020-07-31 17:45 ` [PATCH v5 3/3] ref-filter: add support for %(contents:size) Jeff King
2020-07-31 20:12 ` Christian Couder
2020-07-31 20:30 ` Junio C Hamano
2020-07-31 20:40 ` Jeff King
2020-07-16 17:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8sfjgxkl.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).