From: Junio C Hamano <gitster@pobox.com>
To: "Drew DeVault" <sir@cmpwn.com>
Cc: <git@vger.kernel.org>, "lanodan" <contact+git@hacktivis.me>
Subject: Re: [PATCH v3] help.c: configurable suggestions
Date: Wed, 18 Nov 2020 09:46:10 -0800 [thread overview]
Message-ID: <xmqq8say36e5.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <C76K6Q09ATLR.1OI5KW390LKFX@taiga> (Drew DeVault's message of "Wed, 18 Nov 2020 12:17:43 -0500")
"Drew DeVault" <sir@cmpwn.com> writes:
> On Wed Nov 18, 2020 at 12:16 PM EST, Junio C Hamano wrote:
>> It is unclear from this description alone why this is needed. The
>> seller of this change needs to emphasize how this is better than
>> setting the variable to "0" (do not autocorrect). My guess is that
>> some users do not even need the suggestion of correct spelling when
>> they made a typo?
>
> This is one reason. Another is that spell checking can be
> computationally expensive, and take an annoyingly long time on low-end
> devices.
Both are good reasons to describe in the log message, so that the
next reader of "git log" won't have to ask "why?"
next prev parent reply other threads:[~2020-11-18 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:42 [PATCH v3] help.c: configurable suggestions Drew DeVault
2020-11-18 17:16 ` Junio C Hamano
2020-11-18 17:17 ` Drew DeVault
2020-11-18 17:46 ` Junio C Hamano [this message]
2020-11-18 18:27 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8say36e5.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=contact+git@hacktivis.me \
--cc=git@vger.kernel.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).