From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org, "Denton Liu" <liu.denton@gmail.com>
Subject: Re: [PATCH 1/2] tests: don't mess with fd 7 of test helper functions
Date: Mon, 22 Feb 2021 09:45:06 -0800 [thread overview]
Message-ID: <xmqq8s7g809p.fsf@gitster.g> (raw)
In-Reply-To: <YDLVsjumwSXgEU7k@coredump.intra.peff.net> (Jeff King's message of "Sun, 21 Feb 2021 16:50:42 -0500")
Jeff King <peff@peff.net> writes:
> I agree that 6 is probably reasonable. I wonder if it is worth having a
> master comment describing the function of various descriptors within the
> test suite, so that people know which ones are available for which
> purposes. It is getting awfully crowded in that space.
Thanks for a review.
I had the same impression. I'll wait for a reroll.
prev parent reply other threads:[~2021-02-22 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 19:25 [PATCH 1/2] tests: don't mess with fd 7 of test helper functions SZEDER Gábor
2021-02-21 19:25 ` [PATCH 2/2] test-lib-functions: use BUG() in 'test_must_fail' SZEDER Gábor
2021-02-21 21:58 ` Jeff King
2021-02-22 19:11 ` Jeff King
2021-02-22 19:17 ` Jeff King
2021-02-22 20:02 ` Junio C Hamano
2021-02-21 21:50 ` [PATCH 1/2] tests: don't mess with fd 7 of test helper functions Jeff King
2021-02-22 17:45 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8s7g809p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).