From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 596581F934 for ; Thu, 13 May 2021 21:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233551AbhEMVfF (ORCPT ); Thu, 13 May 2021 17:35:05 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:64457 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233538AbhEMVfE (ORCPT ); Thu, 13 May 2021 17:35:04 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 633FC11DCAD; Thu, 13 May 2021 17:33:54 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=obGCq36WvLKU3YtRQ2PxZazbzhVmzQHtnUDKUF IWEoA=; b=k4UfTD/v6vMEgAYYjCEdGc0WpKN4EpBAI/W0X6uu3yJTPl5Lthd8wA lMF+GsgTE1zj6kwtvVmoRORJkpnyQB2Gw/l6mC1f/UhK9CEKRbGP2Xwi+QQMSjqU zbsuVWqN4JdLcQVyYTr8rElz/jcBHOtJEt7u/5dr23Lp4Pn11SIo8= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 5C5A011DCAC; Thu, 13 May 2021 17:33:54 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 9ED0711DCAB; Thu, 13 May 2021 17:33:51 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Teng Long Cc: git@vger.kernel.org, jonathantanmy@google.com Subject: Re: packfile-uri.txt: fix blobPackfileUri description References: <20210506073354.27833-1-dyroneteng@gmail.com> <20210513071547.64367-1-dyroneteng@gmail.com> Date: Fri, 14 May 2021 06:33:49 +0900 In-Reply-To: <20210513071547.64367-1-dyroneteng@gmail.com> (Teng Long's message of "Thu, 13 May 2021 15:15:47 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E91358CC-B432-11EB-86E4-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Teng Long writes: > Fix the 'uploadpack.blobPackfileUri' description in packfile-uri.txt > and the correct format also can be seen in t5702. > > Signed-off-by: Teng Long > --- > Documentation/technical/packfile-uri.txt | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Will queue; thanks. Jonathan, how does this look? > diff --git a/Documentation/technical/packfile-uri.txt b/Documentation/technical/packfile-uri.txt > index f7eabc6c76..1eb525fe76 100644 > --- a/Documentation/technical/packfile-uri.txt > +++ b/Documentation/technical/packfile-uri.txt > @@ -35,13 +35,14 @@ include some sort of non-trivial implementation in the Minimum Viable Product, > at least so that we can test the client. > > This is the implementation: a feature, marked experimental, that allows the > -server to be configured by one or more `uploadpack.blobPackfileUri= > -` entries. Whenever the list of objects to be sent is assembled, all such > -blobs are excluded, replaced with URIs. As noted in "Future work" below, the > -server can evolve in the future to support excluding other objects (or other > -implementations of servers could be made that support excluding other objects) > -without needing a protocol change, so clients should not expect that packfiles > -downloaded in this way only contain single blobs. > +server to be configured by one or more `uploadpack.blobPackfileUri= > + ` entries. Whenever the list of objects to be > +sent is assembled, all such blobs are excluded, replaced with URIs. As noted > +in "Future work" below, the server can evolve in the future to support > +excluding other objects (or other implementations of servers could be made > +that support excluding other objects) without needing a protocol change, so > +clients should not expect that packfiles downloaded in this way only contain > +single blobs. > > Client design > -------------