From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Bagas Sanjaya" <bagasdotme@gmail.com>,
"Elijah Newren" <newren@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Derrick Stolee" <stolee@gmail.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults
Date: Thu, 15 Jul 2021 16:20:49 -0700 [thread overview]
Message-ID: <xmqq8s27rwoe.fsf@gitster.g> (raw)
In-Reply-To: <pull.1044.v3.git.git.1626309924.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Thu, 15 Jul 2021 00:45:20 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Fix a few small issues with documentation and warnings around the limits for
> the quadratic portion of rename (©) detection, and bump the default
> limits.
>
> Discussion on bumping the limits can be found at [1]. Although it appears we
> generally agree we could switch to an unlimited setting for
> merge.renameLimit, that would require some changes to progress bars to
> notify users how to take action once things start taking a while. So, for
> now, just bump the limits.
>
> [1]
> https://lore.kernel.org/git/CABPp-BFzp3TCWiF1QAVSfywDLYrz=GOQszVM-sw5p0rSB8RWvw@mail.gmail.com/T/#u
>
> Changes since v2:
>
> * Change the meaning of "0" to actually mean unlimited, and modify the
> documentation to mention that.
> * Added 'currently' to descriptions to make it clear the defaults are
> likely to change (again).
> * Added a brief explanation of the exhaustive portion of rename detection,
> as requested by Ævar (though, honestly, I think the thing that actually
> helps people pick values for the limit is the warning that tells people
> that rename detection was skipped and how high they need to set the limit
> if they want to redo the operation and get renames).
Looks sensible. The final phrase chosen ("exhaustive" part) does
sound easy-to-understand, too.
prev parent reply other threads:[~2021-07-15 23:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 0:46 [PATCH 0/3] Improve the documentation and warnings dealing with rename/copy limits Elijah Newren via GitGitGadget
2021-07-11 0:46 ` [PATCH 1/3] doc: clarify documentation for " Elijah Newren via GitGitGadget
2021-07-11 4:37 ` Bagas Sanjaya
2021-07-11 4:52 ` Elijah Newren
2021-07-12 15:03 ` Derrick Stolee
2021-07-12 21:27 ` Junio C Hamano
2021-07-11 0:46 ` [PATCH 2/3] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-11 4:54 ` Eric Sunshine
2021-07-11 4:54 ` Elijah Newren
2021-07-11 0:46 ` [PATCH 3/3] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-12 15:09 ` Derrick Stolee
2021-07-12 18:13 ` Elijah Newren
2021-07-14 0:47 ` Junio C Hamano
2021-07-14 1:06 ` Elijah Newren
2021-07-14 1:10 ` Junio C Hamano
2021-07-14 1:22 ` Elijah Newren
2021-07-14 5:17 ` Junio C Hamano
2021-07-14 15:09 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-14 7:37 ` Ævar Arnfjörð Bjarmason
2021-07-14 16:30 ` Elijah Newren
2021-07-14 22:08 ` Ævar Arnfjörð Bjarmason
2021-07-14 22:56 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 3/4] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-14 16:45 ` Jeff King
2021-07-14 17:17 ` Elijah Newren
2021-07-14 17:33 ` Jeff King
2021-07-14 19:32 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-14 16:43 ` Jeff King
2021-07-14 17:32 ` Elijah Newren
2021-07-14 17:57 ` Jeff King
2021-07-14 20:03 ` Elijah Newren
2021-07-14 20:47 ` Jeff King
2021-07-15 0:45 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 3/4] diffcore-rename: treat a rename_limit of 0 as unlimited Elijah Newren via GitGitGadget
2021-07-15 23:17 ` Junio C Hamano
2021-07-15 0:45 ` [PATCH v3 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-15 13:36 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Derrick Stolee
2021-07-15 23:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8s27rwoe.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).