From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Andrei Rybak <rybak.a.v@gmail.com>,
git@vger.kernel.org, Tom Cook <tom.k.cook@gmail.com>,
"brian m . carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] setup: only die on invalid .git under RUN_SETUP
Date: Fri, 23 Jul 2021 08:21:13 -0700 [thread overview]
Message-ID: <xmqq8s1xqcnq.fsf@gitster.g> (raw)
In-Reply-To: <87tukls7ax.fsf@evledraar.gmail.com> (=?utf-8?B?IsOGdmFyIEFy?= =?utf-8?B?bmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 23 Jul 2021 11:33:30 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>> + int die_on_error = !nongit_ok;
>>> + enum discovery_result discovery;
>>> ... /*
>>> + case GIT_DIR_GITFILE_NOT_A_REPO:
>>> + if (!nongit_ok)
>>> + die(_("not a git repository: %s"), dir.buf);
>>> + *nongit_ok = 1;
>>> + break;
>>> + case GIT_DIR_INVALID_GITFILE:
>>> + if (!nongit_ok)
>>
>> Variable die_on_error could be used in two `if`s above.
>
> Re-reading my own code I think it's better just to drop die_on_error
> entirely and use !nongit_ok consistently, as the rest of the function
> does. What do yo think?
I think "not X_ok" means we do not consider X is OK, and agree with
you that the code is clearer without an extra indirection (I do not
know if you meant to address me, though).
next prev parent reply other threads:[~2021-07-23 15:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 9:17 Bug: All git operations fail when .git contains a non-existent gitdir Tom Cook
2021-07-21 22:58 ` brian m. carlson
2021-07-22 13:13 ` Tom Cook
2021-07-22 14:07 ` [PATCH] setup: only die on invalid .git under RUN_SETUP Ævar Arnfjörð Bjarmason
2021-07-22 19:06 ` Junio C Hamano
2021-07-22 21:08 ` Ævar Arnfjörð Bjarmason
2021-07-23 1:59 ` Junio C Hamano
2021-07-23 8:42 ` Tom Cook
2021-07-22 20:50 ` Andrei Rybak
2021-07-23 9:33 ` Ævar Arnfjörð Bjarmason
2021-07-23 15:21 ` Junio C Hamano [this message]
2021-07-23 8:23 ` Bug: All git operations fail when .git contains a non-existent gitdir Atharva Raykar
2021-07-23 8:39 ` Tom Cook
2021-07-23 15:47 ` Ævar Arnfjörð Bjarmason
2021-07-23 17:02 ` Atharva Raykar
2021-08-30 0:38 ` David Aguilar
2021-08-31 14:16 ` Tom Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8s1xqcnq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=tom.k.cook@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).