git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Evan Miller" <emmiller@gmail.com>,
	git@vger.kernel.org
Subject: Re: Exit code 255 after large clone (32-bit PowerPC)
Date: Mon, 26 Jul 2021 19:20:52 -0700	[thread overview]
Message-ID: <xmqq8s1sfqez.fsf@gitster.g> (raw)
In-Reply-To: <YP9jU194U7S1PFxS@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 27 Jul 2021 01:37:23 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> That message comes from OpenSSH.  I've seen it quite frequently in
> various other (non-Git) cases.  I think it's fair for us to exit
> unsuccessfully if OpenSSH exits unsuccessfully in this case.  For
> example, an attacker could try to tamper with the connection and send
> additional data, which OpenSSH would detect and exit unsuccessfully for.
> We also in general need to detect truncation attacks, which OpenSSH will
> do for us here.
>
> It's possible that if there's an older version of OpenSSH being used,
> that the problem happens to be related to a bug of some sort.  There
> were some versions which had various bugs that could be triggered by a
> rekey, which, if the threshold is set low enough, could be the cause of
> this particular problem.
>
> I think the fact that it's not being seen with HTTPS is the ultimate
> clue here.

This suspiously sounds familiar.  Asking for "close ssh connection"
in the lore.kernel.org archive finds this:

  https://lore.kernel.org/git/YKTg8nYjSGpKbq8W@coredump.intra.peff.net/


  reply	other threads:[~2021-07-27  2:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 17:54 Exit code 255 after large clone (32-bit PowerPC) Evan Miller
2021-07-26 22:09 ` brian m. carlson
2021-07-26 22:50   ` Evan Miller
2021-07-27  0:51   ` Ævar Arnfjörð Bjarmason
2021-07-27  1:37     ` brian m. carlson
2021-07-27  2:20       ` Junio C Hamano [this message]
2021-07-27  3:05         ` Evan Miller
2021-07-27 12:44           ` Jeff King
2021-07-27  2:08     ` Evan Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8s1sfqez.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=emmiller@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).