From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Carlo Arenas" <carenas@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH 1/1] git-compat-util: add a test balloon for C99 supporty
Date: Tue, 23 Nov 2021 12:17:42 -0800 [thread overview]
Message-ID: <xmqq8rxe8w49.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2111231331530.63@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Tue, 23 Nov 2021 13:32:44 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Junio,
>
> On Mon, 22 Nov 2021, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> >> But if we were to do so, perhaps we'd want something like what I
>> >> gave at https://lore.kernel.org/git/xmqqy25lwa86.fsf@gitster.g/ in
>> >> its place to avoid confusing people.
>> >
>> > That sounds like a good course of action to me.
>> >
>> > Please note that the MSVC-related adjustment of the `FLEX_ARRAY` block is
>> > still needed, I think.
>>
>> The "something like what I gave ... to avoid confusing people" patch
>> is following up on the direction to drop the patch with -std=gnu99
>> change. IIRC, your MSVC adjustment was to tweak that patch we were
>> discussing of dropping, so even if it is still needed, it won't be
>> part of what I was doing.
>
> I thought we were only dropping the `--std=gnu99` part, not the change to
> the `git-compat-util.h` header file, nor the patch to the CMake
> configuration for MS Visual C.
Ah, yes, I think these parts need to be kept. I am just dropping
the latest iteration with -std=gnu99 from consideration to merge
down to 'next' and below.
next prev parent reply other threads:[~2021-11-23 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211114211622.1465981-1-sandals@crustytoothpaste.net>
[not found] ` <20211114211622.1465981-2-sandals@crustytoothpaste.net>
2021-11-16 10:30 ` [PATCH 1/1] git-compat-util: add a test balloon for C99 support Johannes Schindelin
2021-11-17 8:29 ` Junio C Hamano
2021-11-22 11:44 ` Johannes Schindelin
2021-11-22 13:05 ` Ævar Arnfjörð Bjarmason
2021-11-22 17:27 ` Junio C Hamano
2021-11-22 17:52 ` Carlo Arenas
2021-11-22 18:58 ` Junio C Hamano
2021-11-22 20:52 ` Junio C Hamano
2021-11-22 22:03 ` [PATCH 1/1] git-compat-util: add a test balloon for C99 supporty Johannes Schindelin
2021-11-22 22:10 ` Junio C Hamano
2021-11-22 22:22 ` Carlo Arenas
2021-11-23 12:32 ` Johannes Schindelin
2021-11-23 20:17 ` Junio C Hamano [this message]
2021-11-24 15:10 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rxe8w49.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).