git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* feature request: add [-f|--from <rootbranch>] to git stash branch
@ 2022-01-13 16:29 Colin Kennedy
  2022-01-14 14:53 ` Philip Oakley
  0 siblings, 1 reply; 3+ messages in thread
From: Colin Kennedy @ 2022-01-13 16:29 UTC (permalink / raw)
  To: git

Current syntax of git stash branch is:

branch <branchname> [<stash>]

Proposed syntax is:

branch <branchname> [-f|--from <rootbranch>] [<stash>]

the from flag specifies a branch from which the new branch should be derived.

Example usage:

git stash branch remove-commented-code --from main

This simplifies a workflow which is common for me. I am working N-commits deep in some feature branch when I discover a low hanging fruit. Dealing with this low hanging fruit is not appropriate for the current feature branch. It's most appropriate to deal with "directly" on a fresh branch from main. Because I am untidy, I often have a bit of mess in between my staging area, and unstaged changes, and this creates friction when I attempt to stash this low hanging fruit, pop back to main, create the new branch, pop the stashed low hanging fruit, etc etc.

The proposed flag gives a one-liner to apply stashed patches wherever, no matter your current location, which I think is an improvement.

Happy to have feedback on the flag. Happy for someone else to implement it. Also happy to consider taking a crack at it myself if it seems like something people would be happy to include. (NB: I haven't written or even read any c, or c++ for that matter, in probably 15 years. So, you know).

thanks,
Colin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: feature request: add [-f|--from <rootbranch>] to git stash branch
  2022-01-13 16:29 feature request: add [-f|--from <rootbranch>] to git stash branch Colin Kennedy
@ 2022-01-14 14:53 ` Philip Oakley
  2022-01-14 19:02   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Philip Oakley @ 2022-01-14 14:53 UTC (permalink / raw)
  To: Colin Kennedy, git

Hi, some minor comments, in-line.

On 13/01/2022 16:29, Colin Kennedy wrote:
> Current syntax of git stash branch is:
>
> branch <branchname> [<stash>]
>
> Proposed syntax is:
>
> branch <branchname> [-f|--from <rootbranch>] [<stash>]

Just to say that the `-f` is typically reserved/used for the --force
option if available.
>
> the from flag specifies a branch from which the new branch should be derived.
>
> Example usage:
>
> git stash branch remove-commented-code --from main
>
> This simplifies a workflow which is common for me. I am working N-commits deep in some feature branch when I discover a low hanging fruit. Dealing with this low hanging fruit is not appropriate for the current feature branch. It's most appropriate to deal with "directly" on a fresh branch from main. Because I am untidy, 
Maybe an example that shows the level of untidiness might help to
clarify the suggestion, as to what is included/not included, and how it
makes it easy later when the stash is recovered.

> I often have a bit of mess in between my staging area, and unstaged changes, and this creates friction when I attempt to stash this low hanging fruit, pop back to main, create the new branch, pop the stashed low hanging fruit, etc etc.
>
> The proposed flag gives a one-liner to apply stashed patches wherever, no matter your current location, which I think is an improvement.
>
> Happy to have feedback on the flag. Happy for someone else to implement it. Also happy to consider taking a crack at it myself if it seems like something people would be happy to include. (NB: I haven't written or even read any c, or c++ for that matter, in probably 15 years. So, you know).
>
> thanks,
> Colin


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: feature request: add [-f|--from <rootbranch>] to git stash branch
  2022-01-14 14:53 ` Philip Oakley
@ 2022-01-14 19:02   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2022-01-14 19:02 UTC (permalink / raw)
  To: Philip Oakley; +Cc: Colin Kennedy, git

Philip Oakley <philipoakley@iee.email> writes:

> Hi, some minor comments, in-line.
>
> On 13/01/2022 16:29, Colin Kennedy wrote:
>> Current syntax of git stash branch is:
>>
>> branch <branchname> [<stash>]
>>
>> Proposed syntax is:
>>
>> branch <branchname> [-f|--from <rootbranch>] [<stash>]
>
> Just to say that the `-f` is typically reserved/used for the --force
> option if available.

True.

Also, a dashed option and its argument should come before the
non-dashed arguments, so if it were a good idea to introduce a new
option, it should come after "git stash branch" and "<branchname>",
not after "<branchname>".

Most importantly, this particular new option is unnecessary and
is probably unwanted.

The original "git stash branch" relieves the user from finding out
the commit where the stash was taken from, which is its value over
its long-hand equivalent, i.e.

	git checkout -b <name> refs/stash^ &&
	git stash pop

The long-hand version forces the user to know that the first parent
of the commit that represents a stash entry is the original commit
the stash entry was taken from.  With "git stash branch <name>", the
user does not need to know it.

But the --from discards the only reason why "stash branch" subcommand
needs to exist.  It would be equivalent to

	git checkout -b <name> <rootbranch> &&
	git stash pop

and it is not helping the user, unlike the original that allowed the
user to be oblivious to the internal implementation detail of a
stash entry.

Or am I failing to see some obvious improvements over the longhand?

Worse, the application and discarding of the stash entry done by the
"git stash branch" is guaranteed to apply cleanly, as we'd be
applying the stash to its exact original state.  The trees of
<rootbranch> and refs/stash^, on the other hand, can be vastly
different, and applying the stash on top of <rootbranch> commit can
fail.

In short, I am not enthused.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-14 19:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13 16:29 feature request: add [-f|--from <rootbranch>] to git stash branch Colin Kennedy
2022-01-14 14:53 ` Philip Oakley
2022-01-14 19:02   ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).