From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 633F91F4D7 for ; Thu, 26 May 2022 17:18:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="inIjKIG3"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244317AbiEZRSH (ORCPT ); Thu, 26 May 2022 13:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232629AbiEZRSF (ORCPT ); Thu, 26 May 2022 13:18:05 -0400 Received: from pb-sasl-trial3.pobox.com (pb-sasl-trial3.pobox.com [64.147.108.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7951B175A5 for ; Thu, 26 May 2022 10:18:04 -0700 (PDT) Received: from pb-sasl-trial3.pobox.com (localhost.local [127.0.0.1]) by pb-sasl-trial3.pobox.com (Postfix) with ESMTP id 494F434892; Thu, 26 May 2022 13:18:03 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=DdK3bjTVeMqN voGJztYyh3MDnk4=; b=inIjKIG3PB+kVt1as5VGHw5+LWqmfP+L6BXAlbSJKcqG XConVbQpYG1GzN/f1/lHATduajol8747Izkw/U3QMhRnq7frl8/AYS9l4Lovsqnh 0B4iUbqXjVmXeBVTDogRLXFyU5moz+UjHNihqxG5JUfZIwV8+R+1nKMySctmvNg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=FJNjju On/JlojyeNkkQvBL3fNVgsYOgtxgzPr5fpMkPfeWpPo8YaQAJvFsz03kxV99GvU/ jEBOWHLL+fedXpOnr2PjSvmvu7JPLY2EaVvm0zWJ8S/b78dDYgq0Pklg553JONvw sfQP4ek2OsfE1T0h+qswG4/cDAAhatEOWsG5E= Received: from pb-smtp1.nyi.icgroup.com (pb-smtp1.pobox.com [10.90.30.53]) by pb-sasl-trial3.pobox.com (Postfix) with ESMTP id 22A5C34891; Thu, 26 May 2022 13:18:03 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4E12B12516F; Thu, 26 May 2022 13:18:02 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Jiang Xin , Git List , Jiang Xin , Alexander Shopov , Jordi Mas , Matthias =?utf-8?Q?R=C3=BCster?= , Jimmy Angelakos , Christopher =?utf-8?Q?D=C3=ADaz?= , =?utf-8?Q?Jean-No=C3=ABl?= Avila , Bagas Sanjaya , Alessandro Menti , Gwan-gyeong Mun , Arusekk , Daniel Santos , Dimitriy Ryazantcev , Peter Krefting , Emir SARI , =?utf-8?B?VHLhuqduIE5n4buNYyBRdcOibg==?= , Fangyi Zhou , Yi-Jyun Pan Subject: Re: [PATCH] Makefile: dedup git-ls-files output to prevent duplicate targets References: <20220526021540.2812-1-worldhello.net@gmail.com> <220526.86tu9c625s.gmgdl@evledraar.gmail.com> Date: Thu, 26 May 2022 10:18:00 -0700 In-Reply-To: <220526.86tu9c625s.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Thu, 26 May 2022 12:00:04 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: CC50F7EE-DD17-11EC-9E71-5E84C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > I pointed out then that with --sort-by-file added we: > > * Don't group the translations by C/SH/Perl anymore > * Change the sort order within files, to be line/sorted instead of > line/order (i.e. first occurring translations first) > > I suggested then to just use $(sort) on the respective lists. > > So why not just: > > 1. Switch to the $(FOUND_C_SOURCES) (good) > 2. Filter that by C/Perl/SH as before (just a simple $(filter) > 3. $(sort) that (which as noted, also de-dupes it) > > Then we don't have any of the behavior change of --sort-by-file, and we > don't have to carefully curate the ls-files/find commands to not includ= e > duplicates (although as seen here that seems to have been a useful > canary in the "find" case). Does "--sort-by-file" really mean that? The option is documented to sort output by file location, but does it mean without the option (i.e. default), there is no guarantee in the output order? Or are we sure that the output is sorted by the order of input files, and that is guaranteed to hold in the future? If we are depending on certain ordering of the output produced by gettext suite of programs, I would keep the option, regardless of what we do to the input to them, if I were running the i18n part of this project. But I am not, so I would not complain if --sort-by-file is dropped against my advice ;-)