From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 96CEC1F727 for ; Thu, 30 Jun 2022 20:52:52 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="nsK7Cer+"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237368AbiF3Uwd (ORCPT ); Thu, 30 Jun 2022 16:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237307AbiF3Uw1 (ORCPT ); Thu, 30 Jun 2022 16:52:27 -0400 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D94493878A for ; Thu, 30 Jun 2022 13:52:26 -0700 (PDT) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5EDC01A867E; Thu, 30 Jun 2022 16:52:26 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Wjk1mOvolp3u 1gyazgIT4l79KFAHd1bgWwyxqcIF2F4=; b=nsK7Cer+WeQo6D9nxfkJ2yf0SD6S Bn8IS0w26v/zjHGlvNZDPYdZYju34aCF+Mvr/NEl0wzD5JZsW1gdPZbNnXap79Iy kkPYbgVF5BxRt3VvjFvw8Abm7zqgRCgwu07s/LvXhYMRQdPIEHEuUz0kLoDPHaP4 Mi9Iw1LRjfMdirA= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 569B91A867D; Thu, 30 Jun 2022 16:52:26 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id CE0C21A867B; Thu, 30 Jun 2022 16:52:22 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Derrick Stolee , rsbecker@nexbridge.com, SZEDER =?utf-8?Q?G=C3=A1bor?= , Johannes Sixt , Jeff King Subject: Re: [PATCH v2 3/3] config tests: fix harmless but broken "rm -r" cleanup References: Date: Thu, 30 Jun 2022 13:52:21 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Thu, 30 Jun 2022 12:18:36 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 8A3C9B14-F8B6-11EC-B751-C85A9F429DF0-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > diff --git a/t/t1300-config.sh b/t/t1300-config.sh > index d3d9adbb3db..c6661e61af5 100755 > --- a/t/t1300-config.sh > +++ b/t/t1300-config.sh > @@ -2083,12 +2083,13 @@ test_expect_success '--show-scope with --show-o= rigin' ' > ' > =20 > test_expect_success 'override global and system config' ' > - test_when_finished rm -f "$HOME"/.config/git && > - > + test_when_finished rm -f \"\$HOME\"/.gitconfig && This does look more correct than the original. > cat >"$HOME"/.gitconfig <<-EOF && > [home] > config =3D true > EOF > + > + test_when_finished rm -rf \"\$HOME\"/.config/git && > mkdir -p "$HOME"/.config/git && > cat >"$HOME"/.config/git/config <<-EOF && > [xdg] Nicely done. Will queue. Thanks.