mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Gwyneth Morgan <>
Subject: Re: [PATCH] request-pull: filter out SSH/X.509 tag signatures
Date: Wed, 25 Jan 2023 15:19:34 -0800	[thread overview]
Message-ID: <xmqq8rhqdwxl.fsf@gitster.g> (raw)
In-Reply-To: <> (Gwyneth Morgan's message of "Wed, 25 Jan 2023 23:01:17 +0000")

Gwyneth Morgan <> writes:

> git request-pull filters PGP signatures out of the tag message, but not
> SSH or X.509 signatures.
> ---

Please sign-off your contribution. 
cf.  Documentation/SubmittingPatches[[sign-off]]

> | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/ b/
> index 2d0e44656c..01640a044b 100755
> --- a/
> +++ b/
> @@ -153,7 +153,7 @@ for you to fetch changes up to %H:
>  if test $(git cat-file -t "$head") = tag
>  then
>  	git cat-file tag "$head" |
> -	sed -n -e '1,/^$/d' -e '/^-----BEGIN PGP /q' -e p
> +	sed -n -e '1,/^$/d' -e '/^-----BEGIN \(PGP\|SSH\|SIGNED\) /q' -e p

This makes readers debate themselves if being more specific and
narrow like the posted patch is safer and better, or making it
looser by just requiring "^-----BEGIN " and making it forward
looking is sufficient and maintainable.

If this were signed-off already, I would have said "let's queue it
as-is, while waiting for input from others", but without a sign-off
I am not queuing (yet).


  reply	other threads:[~2023-01-25 23:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 23:01 [PATCH] request-pull: filter out SSH/X.509 tag signatures Gwyneth Morgan
2023-01-25 23:19 ` Junio C Hamano [this message]
2023-01-25 23:45   ` Gwyneth Morgan
2023-01-25 23:47 ` [PATCH v2] " Gwyneth Morgan
2023-01-26  0:18   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8rhqdwxl.fsf@gitster.g \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).