From: Junio C Hamano <gitster@pobox.com>
To: Vinayak Dev <vinayakdev.sci@gmail.com>
Cc: sunshine@sunshineco.com, git@vger.kernel.org
Subject: Re: [PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums
Date: Fri, 10 Feb 2023 14:01:56 -0800 [thread overview]
Message-ID: <xmqq8rh5gox7.fsf@gitster.g> (raw)
In-Reply-To: <20230210171338.81906-1-vinayakdev.sci@gmail.com> (Vinayak Dev's message of "Fri, 10 Feb 2023 22:43:35 +0530")
Vinayak Dev <vinayakdev.sci@gmail.com> writes:
> Revert changes to alias.c, and change variable types in apply.c
When you send out a rerolled series, you do not have to show your
past mistakes. This [v2] is structured as a three patch series
whose first one makes a similar mess as what [v1] did, the second
one and the third one then revert some parts of that earlier mess.
That is not what you want to show your reviewers, and more
importantly, that is not what we want to record in our history.
Rerolling a series is your chance to pretend that you are much
better programmer than you who wrote the [v1] patch. The review
exchange is to help you do that. Please take advantage of that.
You may find "git rebase -i" is a useful tool to help you pretend
that you got to the ideal end result without these "I tried this
first, which was wrong in these points, which I correct in a
subsequent step" steps.
Thanks.
next prev parent reply other threads:[~2023-02-10 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 17:13 [PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums Vinayak Dev
2023-02-10 17:13 ` [PATCH v2 1/3] " Vinayak Dev
2023-02-10 17:13 ` [PATCH v2 2/3] " Vinayak Dev
2023-02-10 17:13 ` [PATCH v2 3/3] " Vinayak Dev
2023-02-10 22:01 ` Junio C Hamano [this message]
2023-02-11 4:00 ` [PATCH v2 0/3] " Vinayak Dev
2023-02-15 0:04 ` Eric Sunshine
2023-02-15 8:19 ` Vinayak Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rh5gox7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=vinayakdev.sci@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).