git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Charles Bailey <charles@hashpling.org>, git@vger.kernel.org
Subject: Re: [PATCH v2] Fix detection of uname failure
Date: Fri, 17 Jul 2015 14:39:56 -0700	[thread overview]
Message-ID: <xmqq7fpy1n0z.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <7cf6757e8e81c2f9e102db24efbedb2a@www.dscho.org> (Johannes Schindelin's message of "Fri, 17 Jul 2015 23:07:55 +0200")

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> On 2015-07-17 19:09, Charles Bailey wrote:
>> From: Charles Bailey <cbailey32@bloomberg.net>
>> 
>> According to POSIX specification uname must return -1 on failure and a
>> non-negative value on success. Although many implementations do return 0
>> on success it is valid to return any positive value for success.  In
>> particular, Solaris returns 1.
>> 
>> Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

I'd s/Ack/Review/; as the original is not your code but you are well
qualified (and have my trust) to judge the change to this codepath
;-)

Thanks.

  reply	other threads:[~2015-07-17 21:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 12:11 [PATCH] Fix detection of uname failure Charles Bailey
2015-07-17 13:06 ` Johannes Schindelin
2015-07-17 17:01   ` Charles Bailey
2015-07-17 17:09     ` Junio C Hamano
2015-07-17 17:09   ` [PATCH v2] " Charles Bailey
2015-07-17 21:07     ` Johannes Schindelin
2015-07-17 21:39       ` Junio C Hamano [this message]
2015-07-18  6:58         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fpy1n0z.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=charles@hashpling.org \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).