From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 10/10] t/t9001-send-email.sh: get rid of unnecessary backquotes
Date: Fri, 08 Jan 2016 10:12:37 -0800 [thread overview]
Message-ID: <xmqq7fjk2b56.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <vpqa8ogdsyr.fsf@anie.imag.fr> (Matthieu Moy's message of "Fri, 08 Jan 2016 15:52:12 +0100")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Elia Pinto <gitter.spiros@gmail.com> writes:
>
>> Instead of making the shell expand 00* and invoke 'echo' with it,
>> and then capturing its output as command substitution, just use
>> the result of expanding 00* directly.
>
> This is not actually how it happens. cover=`echo *` expands the * before
> the assignment to $cover, while cover="*" assigns a litteral * to
> $cover.
>
> Then, when you use $cover, the variable is expanded to * and then it is
> expanded to filenames here:
>
>> mv $cover cover-to-edit.patch &&
>
> On the other hand, this instance of $cover is quoted, hence the
> *-expansion won't happen:
>
>> perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&
>
> So, I believe this patch is not correct.
I think this tried to mimick 6ffd3ec8 but the context covered by
that commit is different from the right hand side of an assignment.
You are right that [10/10] changes where the expansion happens and
is not a faithful conversion. The result may be the same, though ;-)
If anything, I think
- mv $cover cover-to-edit.patch &&
+ mv "$cover" cover-to-edit.patch &&
is a prudent thing to do, but that is orthogonal to what 10/10
tried to do.
>
> OTOH, patches 1 to 9 look good to me.
next prev parent reply other threads:[~2016-01-08 18:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 11:06 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2016-01-08 11:06 ` [PATCH 01/10] t/t7103-reset-bare.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 02/10] t/t7406-submodule-update.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 03/10] t/t7408-submodule-reference.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 04/10] t/t7504-commit-msg-hook.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 05/10] t/t7505-prepare-commit-msg-hook.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 06/10] t/t7602-merge-octopus-many.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 07/10] t/t7700-repack.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 08/10] t/t8003-blame-corner-cases.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 09/10] t/t9001-send-email.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 10/10] t/t9001-send-email.sh: get rid of unnecessary backquotes Elia Pinto
2016-01-08 14:52 ` Matthieu Moy
2016-01-08 18:12 ` Junio C Hamano [this message]
2016-01-08 22:29 ` Elia Pinto
2016-01-08 22:37 ` Junio C Hamano
2016-01-08 23:19 ` Elia Pinto
2016-01-08 20:07 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fjk2b56.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).