From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 4/6] config: return configset value for current_config_ functions
Date: Thu, 26 May 2016 09:42:48 -0700 [thread overview]
Message-ID: <xmqq7fegydmf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACsJy8Ad=yN6aLkH9B6ujUNUvPT-b+jw+CwJORD5Fh1jYeOUZQ@mail.gmail.com> (Duy Nguyen's message of "Thu, 26 May 2016 14:47:15 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> On Thu, May 19, 2016 at 7:08 AM, Jeff King <peff@peff.net> wrote:
>> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote:
>>
>>> cache.h | 1 +
>>> config.c | 51 +++++++++++++++++++++++++++++++++++++++++---------
>>> t/helper/test-config.c | 20 ++++++++++++++++++++
>>> t/t1308-config-set.sh | 23 +++++++++++++++++++++++
>>> [...]
>>> +test_expect_success 'iteration shows correct origins' '
>>> + echo "[alias]test-config = !test-config" >.gitconfig &&
>
> How about using 'which' to get absolute path for test-config and put
> it here? Then we don't rely on $PATH anymore.
Don't use which, which is not portable.
Remind me why we end up running ./test-config instead of
./bin-wrappers/test-config? Should our tests be running
bin-wrappers early in their $PATH, perhaps?
next prev parent reply other threads:[~2016-05-26 16:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 22:37 [PATCH/RFC 0/6] pack-objects hook for upload-pack Jeff King
2016-05-18 22:39 ` [PATCH 1/6] git_config_with_options: drop "found" counting Jeff King
2016-05-18 22:39 ` [PATCH 2/6] git_config_parse_parameter: refactor cleanup code Jeff King
2016-05-18 22:41 ` [PATCH 3/6] config: set up config_source for command-line config Jeff King
2016-05-18 22:43 ` [PATCH 4/6] config: return configset value for current_config_ functions Jeff King
2016-05-19 0:08 ` Jeff King
2016-05-26 7:47 ` Duy Nguyen
2016-05-26 16:42 ` Junio C Hamano [this message]
2016-05-26 16:50 ` Jeff King
2016-05-26 17:36 ` Junio C Hamano
2016-05-27 0:41 ` Jeff King
2016-05-27 2:11 ` Junio C Hamano
2016-05-27 0:32 ` Jeff King
2016-05-18 22:44 ` [PATCH 5/6] config: add a notion of "scope" Jeff King
2016-05-18 22:45 ` [PATCH 6/6] upload-pack: provide a hook for running pack-objects Jeff King
2016-05-19 0:14 ` Jeff King
2016-05-19 10:12 ` Ævar Arnfjörð Bjarmason
2016-05-19 12:08 ` Jeff King
2016-05-19 14:54 ` Ævar Arnfjörð Bjarmason
2016-05-26 5:37 ` Jeff King
2016-05-25 0:59 ` [PATCH/RFC 0/6] pack-objects hook for upload-pack Junio C Hamano
2016-05-26 5:44 ` Jeff King
2016-05-26 16:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fegydmf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).