From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Simon Courtois <scourtois@cubyx.fr>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] color: support "italic" attribute
Date: Thu, 23 Jun 2016 09:46:57 -0700 [thread overview]
Message-ID: <xmqq7fdfkg3i.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160623131028.GB12653@sigill.intra.peff.net> (Jeff King's message of "Thu, 23 Jun 2016 09:10:28 -0400")
Jeff King <peff@peff.net> writes:
> We already support bold, underline, and similar attributes.
> Let's add italic to the mix. According to the Wikipedia
> page on ANSI colors, this attribute is "not widely
> supported", but it does seem to work on my xterm.
>
> We don't have to bump the maximum color size because we were
> already over-allocating it (but we do adjust the comment
> appropriately).
>
> Requested-by: Simon Courtois <scourtois@cubyx.fr>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Documentation/config.txt | 2 +-
> color.c | 8 ++++----
> color.h | 3 ++-
> t/t4026-color.sh | 4 ++--
> 4 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 58673cf..4b97d8d 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -154,7 +154,7 @@ color::
> colors (at most two) and attributes (at most one), separated
This is describing the format accepted by color_parse_mem(), whose
main loop has /* [fg [bg]] [attr]... */ comment in front?
Is "at most one" still correct, or it was already stale before this
patch?
next prev parent reply other threads:[~2016-06-23 16:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:54 Italics formatting Simon Courtois
2016-06-23 13:08 ` [PATCH 0/2] more ANSI attributes Jeff King
2016-06-23 13:09 ` [PATCH 1/2] color: fix max-size comment Jeff King
2016-06-23 13:10 ` [PATCH 2/2] color: support "italic" attribute Jeff King
2016-06-23 13:57 ` Simon Courtois
2016-06-23 16:46 ` Junio C Hamano [this message]
2016-06-23 16:47 ` Jeff King
2016-06-23 17:30 ` [PATCH v2 0/7] more ANSI attributes Jeff King
2016-06-23 17:31 ` [PATCH v2 1/7] color: fix max-size comment Jeff King
2016-06-23 17:32 ` [PATCH v2 2/7] doc: refactor description of color format Jeff King
2016-06-23 17:33 ` [PATCH v2 3/7] add skip_prefix_mem helper Jeff King
2016-06-23 17:38 ` [PATCH v2 4/7] color: refactor parse_attr Jeff King
2016-06-23 17:38 ` [PATCH v2 5/7] color: allow "no-" for negating attributes Jeff King
2016-06-23 17:39 ` [PATCH v2 6/7] color: support "italic" attribute Jeff King
2016-06-23 18:34 ` Junio C Hamano
2016-06-23 18:36 ` Jeff King
2016-06-23 17:40 ` [PATCH v2 7/7] color: support strike-through attribute Jeff King
2016-06-23 18:36 ` Junio C Hamano
2016-06-23 18:39 ` Jeff King
2016-06-23 18:52 ` Junio C Hamano
2016-06-23 19:03 ` Junio C Hamano
2016-06-23 19:04 ` Jeff King
2016-06-23 19:11 ` Junio C Hamano
2016-06-23 19:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fdfkg3i.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=scourtois@cubyx.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).