From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Dennis Kaarsemaker" <dennis@kaarsemaker.net>,
git@vger.kernel.org, "Brandon Williams" <bmwill@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2] send-email: Net::SMTP::SSL is obsolete, use only when necessary
Date: Thu, 01 Jun 2017 07:39:16 +0900 [thread overview]
Message-ID: <xmqq7f0wabxn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170531214634.GB81679@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Wed, 31 May 2017 14:46:34 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Dennis Kaarsemaker wrote:
>
>> Net::SMTP itself can do the necessary SSL and STARTTLS bits just fine
>> since version 1.28, and Net::SMTP::SSL is now deprecated. Since 1.28
>> isn't that old yet, keep the old code in place and use it when
>> necessary.
>
> This broke git send-email for me. The error message is
>
> Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410.
>
> Is 1.28 the right minimum version?
>
> $ perl -e 'require Net::SMTP; print version->parse($Net::SMTP::VERSION); print "\n"'
> 2.31
> $ grep VERSION /usr/share/perl/5.18.2/Net/SMTP.pm
> use vars qw($VERSION @ISA);
> $VERSION = "2.31";
> $ grep starttls /usr/share/perl/5.18.2/Net/SMTP.pm
> $ dpkg-query -W perl
> perl 5.18.2-2ubuntu1.1
>
Thanks.
Let's revert the merge for now until we know (this time for certain)
what the minimum version is.
next prev parent reply other threads:[~2017-05-31 22:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 21:18 [PATCH] Remove dependency on deprecated Net::SMTP::SSL Mike Fisher
2016-11-20 21:53 ` brian m. carlson
2017-01-13 14:59 ` Renato Botelho
2016-11-21 5:37 ` Torsten Bögershausen
2017-03-18 22:23 ` [PATCH] send-email: Net::SMTP::SSL is obsolete, use only when necessary Dennis Kaarsemaker
2017-03-18 22:47 ` Ævar Arnfjörð Bjarmason
2017-03-18 23:14 ` Dennis Kaarsemaker
2017-03-24 21:37 ` [PATCH v2] " Dennis Kaarsemaker
2017-05-04 7:01 ` Dennis Kaarsemaker
2017-05-19 20:54 ` Dennis Kaarsemaker
2017-05-20 7:56 ` Ævar Arnfjörð Bjarmason
2017-05-31 22:50 ` Junio C Hamano
2017-06-01 19:42 ` Dennis Kaarsemaker
2017-05-31 21:46 ` Jonathan Nieder
2017-05-31 22:39 ` Junio C Hamano [this message]
2017-05-31 22:53 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f0wabxn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).