From: Junio C Hamano <gitster@pobox.com>
To: astian <astian@eclipso.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] Doc/config.txt: explain repeated sections
Date: Sun, 09 Jul 2017 00:57:07 -0700 [thread overview]
Message-ID: <xmqq7ezi9h64.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqfue6a5va.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Sat, 08 Jul 2017 16:03:37 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> +Multiple occurrences of the same section are all logically merged. (There's
>> +no special treatment for variables defined multiple times across physically
>> +different sections, the variable is simply made multivalued.)
>> +
>
> Looks correct; it's a bit surprising that we didn't already mention
> multiple occurrences, but I do not find it so this is a good
> addition.
>
> I do not see a strong reason for () around the second sentence,
> though.
After re-reading this, I am wondering if the "made multivalued"
above need to be made less confusing. For a variable that is single
valued, the usual "the last one wins" rule is applied---it's not
like
[user]
name = astian
name = gitster
makes user.name "gitster" while
[user]
name = astian
[user]
name = gitster
makes user.name "multivalued". In either case, the last one wins,
and it comes not from the syntax but from the semantics assigned to
the variable in question. What we want to say is not "multi-valued",
but the above two forms both mean the same thing.
But perhaps I am needlessly worried about possible confusion too
much. I dunno.
Thanks.
next prev parent reply other threads:[~2017-07-09 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 20:34 [PATCH 0/4] Misc. documentation fixes astian
2017-07-08 20:34 ` [PATCH 1/4] Doc/config.txt: explain repeated sections astian
2017-07-08 23:03 ` Junio C Hamano
2017-07-09 7:57 ` Junio C Hamano [this message]
2017-07-10 7:32 ` Jeff King
2017-07-10 16:17 ` Junio C Hamano
2017-07-08 20:34 ` [PATCH 2/4] Doc/config.txt: fix typos astian
2017-07-08 20:34 ` [PATCH 3/4] Doc/git-send-email.txt: clarify a couple of options astian
2017-07-08 20:34 ` [PATCH 4/4] Doc/config.txt: fix documentation for smtpEncryption astian
2017-07-08 23:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ezi9h64.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=astian@eclipso.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).