From: Junio C Hamano <firstname.lastname@example.org> To: Max Rothman <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] completion: add missing completions for log, diff, show Date: Wed, 08 Nov 2017 11:33:13 +0900 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Max Rothman's message of "Tue, 7 Nov 2017 21:22:47 +0000") Max Rothman <email@example.com> writes: > From: Max Rothman <firstname.lastname@example.org> Thanks. > > Teach git-log tab completion about the --no-* options for ease of use > at the command line. > > Similarly, teach git-show tab completion about the --no-abbrev-commit, > --expand-tabs, and --no-expand-tabs options. > > Also, teach git-diff (and all commands that use its options) tab > completion about the --textconv and --indent-heuristic families of > options. --indent-heuristic is no longer experimental, so there's no > reason it should be left out of tab completion any more, and textconv > seems to have simply been missed. A couple of things that I found questionable in the above descriptions are: * We do not write git subcommand names like git-foo these days, as nobody type them like so. * The patch is not teaching git-foo about completing its options. It teaches the bash completion about options for git subcommands it did not know about. So perhaps The bash completion script knows some options to the "git log" only in the positive form (e.g. "--abbrev-commit") but not in their negated form (e.g. "--no-abbrev-commit"). Add them. and similar? > --- Missed sign-off? > @@ -1759,16 +1765,19 @@ _git_log () > ... > - --decorate --decorate= > + --decorate --decorate= --no-decorate > ... > @@ -2816,8 +2825,9 @@ _git_show () > return > ;; > --*) > - __gitcomp "--pretty= --format= --abbrev-commit --oneline > - --show-signature > + __gitcomp "--pretty= --format= --abbrev-commit --no-abbrev-commit > + --oneline --show-signature --patch > + --expand-tabs --expand-tabs= --no-expand-tabs > $__git_diff_common_options > " > return It's a bit sad that the completion support does not know that "git show" belongs to the "git log" family of commands. A consequence of this is that "git show --no-decorate" is perfectly acceptable but needs to be taught separately to _git_show if we wanted to. Perhaps some selected options _git_log understands may need to be split $__git_log_ui_common_options [*1*], like we do for "git diff" family with $__git_diff_common_options, and shared between _git_log and _git_show. I am mentioning this primarily as #leftoverbits and I do not want to see such a change mixed into this patch, as it is totally outside the scope of it. It is (if you are inclined to do so) OK to make this into two patch series, with 1/2 doing such a refactoring without changing any externally visible functionality (i.e. just move the ones _git_show knows about to $__git_log_ui_common_options, and have _git_show and _git_log use it), and 2/2 adding more options to that list to achieve what you wanted to do with this patch, though. Thanks. [Footnote] *1* $__git_log_common_options is taken and it is about options common to "log/shortlog/gitk" but contains some that are not relevant to "git show", and that is why I am suggesting a separate and new variable.
next prev parent reply other threads:[~2017-11-08 2:33 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-11 14:47 No log --no-decorate completion? Max Rothman 2017-10-11 18:09 ` Stefan Beller 2017-10-12 17:41 ` Max Rothman 2017-10-24 15:32 ` Max Rothman [not found] ` <CAFA_24K99LkeJBKV7+a-m-m9PUZik49cOd40+cEn-6zCvGmMsQ@mail.gmail.com> 2017-10-24 15:32 ` Stefan Beller 2017-11-02 20:25 ` Max Rothman 2017-11-02 21:19 ` Stefan Beller 2017-11-07 20:31 ` Max Rothman 2017-11-07 20:48 ` Stefan Beller 2017-11-07 21:22 ` [PATCH] completion: add missing completions for log, diff, show Max Rothman 2017-11-08 2:33 ` Junio C Hamano [this message] 2017-11-08 3:30 ` Max Rothman 2017-11-08 4:06 ` Junio C Hamano 2019-07-02 1:56 ` Max Rothman 2019-08-02 0:54 ` Max Rothman 2019-09-11 18:15 ` Max Rothman 2019-09-12 8:54 ` Johannes Schindelin 2019-09-12 19:47 ` Junio C Hamano [not found] ` <CAFA_24L5S1_AS1OzPYf50iXwEupi0Bus827-NWoUpka-avNo_w@mail.gmail.com> 2019-09-13 21:03 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] completion: add missing completions for log, diff, show' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).