From: Junio C Hamano <firstname.lastname@example.org>
To: Casey Fitzpatrick <email@example.com>
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
Subject: Re: [PATCH v4 0/3] Add --progress and --dissociate to git submodule
Date: Thu, 17 May 2018 11:48:43 +0900 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Casey Fitzpatrick's message of "Thu, 3 May 2018 06:53:43 -0400")
Casey Fitzpatrick <email@example.com> writes:
> These patches add --progress and --dissociate options to git submodule.
> The --progress option existed beforehand, but only for the update command and
> it was left undocumented.
> Both add and update submodule commands supported --reference, but not its pair
> option --dissociate which allows for independent clones rather than depending
> on the reference.
This round hasn't seen any further comment, and I think all the
previously raised issues have been resolved in this version, so
I am tempted to merge it to 'next'.
One thing that I noticed is that "git submodule -h" does not give
any hint about --dissociate even though it talks about --reference
with these patches applied, and I think it probably should [*1*].
We can make such an update as incremental patch on top of these, if
people cared enough about this, without a further reroll of these
*1* It's not like we must list each and every option available---it
is perfectly fine to omit less common ones to keep the "-h" output
manageably short. But I have a feeling that "--reference" and
"--dissociate" should probably be at a similar level of importance,
and if we list one we probably should show the other, too.
prev parent reply other threads:[~2018-05-17 2:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:53 [PATCH v4 0/3] Add --progress and --dissociate to git submodule Casey Fitzpatrick
2018-05-03 10:53 ` [PATCH v4 1/3] submodule: clean up subsititions in script Casey Fitzpatrick
2018-05-03 10:53 ` [PATCH v4 2/3] submodule: add --progress option to add command Casey Fitzpatrick
2018-05-03 10:53 ` [PATCH v4 3/3] submodule: add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-17 2:48 ` Junio C Hamano [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).