* [PATCH] config: document value 2 for protocol.version
@ 2018-05-22 22:27 Brandon Williams
2018-05-22 22:32 ` Jonathan Nieder
0 siblings, 1 reply; 5+ messages in thread
From: Brandon Williams @ 2018-05-22 22:27 UTC (permalink / raw)
To: git, bmwill; +Cc: Brandon Williams
Update the config documentation to note the value `2` as an acceptable
value for the protocol.version config.
Signed-off-by: Brandon Williams <bmwill@google.com>
---
Documentation/config.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index a05a88fec..ce778883d 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -2637,6 +2637,8 @@ protocol.version::
* `1` - the original wire protocol with the addition of a version string
in the initial response from the server.
+* `2` - wire protocol version 2.
+
--
pull.ff::
--
2.17.0.441.gb46fe60e1d-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] config: document value 2 for protocol.version
2018-05-22 22:27 [PATCH] config: document value 2 for protocol.version Brandon Williams
@ 2018-05-22 22:32 ` Jonathan Nieder
2018-09-10 21:21 ` [PATCH v2] " Josh Steadmon
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Nieder @ 2018-05-22 22:32 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
Brandon Williams wrote:
> Update the config documentation to note the value `2` as an acceptable
> value for the protocol.version config.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> Documentation/config.txt | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index a05a88fec..ce778883d 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2637,6 +2637,8 @@ protocol.version::
> * `1` - the original wire protocol with the addition of a version string
> in the initial response from the server.
>
> +* `2` - wire protocol version 2.
> +
> --
Should this mention where the user can find more details (e.g. by
saying link:technical/protocol-v2.html[protocol version 2])?
See the reference to the credentials API in "git help credentials" for
an example of how that renders.
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] config: document value 2 for protocol.version
2018-05-22 22:32 ` Jonathan Nieder
@ 2018-09-10 21:21 ` Josh Steadmon
2018-09-10 21:30 ` Jonathan Nieder
0 siblings, 1 reply; 5+ messages in thread
From: Josh Steadmon @ 2018-09-10 21:21 UTC (permalink / raw)
To: git; +Cc: jrn, Brandon Williams, Josh Steadmon
From: Brandon Williams <bmwill@google.com>
Update the config documentation to note the value `2` as an acceptable
value for the protocol.version config.
Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Josh Steadmon <steadmon@google.com>
---
Documentation/config.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index eb66a1197..ee3b5dd8e 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -2828,6 +2828,8 @@ protocol.version::
* `1` - the original wire protocol with the addition of a version string
in the initial response from the server.
+* `2` - link:technical/protocol-v2.html[wire protocol version 2].
+
--
pull.ff::
--
2.19.0.rc2.392.g5ba43deb5a-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] config: document value 2 for protocol.version
2018-09-10 21:21 ` [PATCH v2] " Josh Steadmon
@ 2018-09-10 21:30 ` Jonathan Nieder
2018-09-10 22:00 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Nieder @ 2018-09-10 21:30 UTC (permalink / raw)
To: Josh Steadmon; +Cc: git, Junio C Hamano
Josh Steadmon wrote:
> From: Brandon Williams <bmwill@google.com>
>
> Update the config documentation to note the value `2` as an acceptable
> value for the protocol.version config.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> Documentation/config.txt | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] config: document value 2 for protocol.version
2018-09-10 21:30 ` Jonathan Nieder
@ 2018-09-10 22:00 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2018-09-10 22:00 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Josh Steadmon, git
Jonathan Nieder <jrnieder@gmail.com> writes:
> Josh Steadmon wrote:
>
>> From: Brandon Williams <bmwill@google.com>
>>
>> Update the config documentation to note the value `2` as an acceptable
>> value for the protocol.version config.
>>
>> Signed-off-by: Brandon Williams <bmwill@google.com>
>> Signed-off-by: Josh Steadmon <steadmon@google.com>
>> ---
>> Documentation/config.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-10 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 22:27 [PATCH] config: document value 2 for protocol.version Brandon Williams
2018-05-22 22:32 ` Jonathan Nieder
2018-09-10 21:21 ` [PATCH v2] " Josh Steadmon
2018-09-10 21:30 ` Jonathan Nieder
2018-09-10 22:00 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).