From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
git@vger.kernel.org
Subject: Re: pw/rebase-abort-clean-rewritten, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)
Date: Mon, 17 Jun 2019 20:30:04 -0700 [thread overview]
Message-ID: <xmqq7e9jsh8j.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <2a37d4c2-6eec-548d-0bd0-12bbd49c8071@gmail.com> (Phillip Wood's message of "Mon, 17 Jun 2019 20:04:00 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Yes I sent it just before I went offline, but that's a while ago now
Yup. IIRC, you told us not to look at the patch "for now" as you
would be offline, and I was fully expecting that a regular review
exchange would happen after you come back.
I do not recall seeing much discussion, though, but ...
>> Phillip, I was under the impression that all reviewer comments had been
>> resolved. Does that match your impression?
>
> Yes, I think it's ready. Thanks for prompting me dscho, I'd seen this
> was on hold and then forgotten to write to Junio
... if you resolved "all reviewer comments", it must have seen
sufficient review, in which case let's merge it to 'next'.
Thanks.
next prev parent reply other threads:[~2019-06-18 3:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:50 What's cooking in git.git (Jun 2019, #04; Fri, 14) Junio C Hamano
2019-06-17 17:41 ` js/gcc-8-and-9, was " Johannes Schindelin
2019-06-17 19:54 ` Junio C Hamano
2019-06-18 10:26 ` Johannes Schindelin
2019-06-19 14:28 ` Junio C Hamano
2019-06-17 18:06 ` pw/rebase-abort-clean-rewritten, " Johannes Schindelin
2019-06-17 19:04 ` Phillip Wood
2019-06-18 3:30 ` Junio C Hamano [this message]
2019-06-20 9:34 ` Phillip Wood
2019-06-21 13:27 ` Johannes Schindelin
2019-06-17 18:25 ` sg/rebase-progress, " Johannes Schindelin
2019-06-18 13:36 ` ds/commit-graph-incremental (was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)) Derrick Stolee
2019-06-19 14:32 ` Junio C Hamano
2019-06-19 14:37 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7e9jsh8j.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).