git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t: use LF variable defined in the test harness
Date: Thu, 05 Sep 2019 11:17:57 -0700	[thread overview]
Message-ID: <xmqq7e6mr4iy.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190904002930.GA76383@syl.lan> (Taylor Blau's message of "Tue, 3 Sep 2019 20:29:30 -0400")

Taylor Blau <me@ttaylorr.com> writes:

>   - t/t3005: this script calls the variable '$new_line', but could be
>     renamed to LF and then removed in a second patch

It is worse than that, isn't it?

If it used $new_line, then it would probably have been a good idea
to somehow make a separate patch related to this one and make a
series about "use $LF from test-lib", but ever since its beginning
at 0f64bfa9 ("ls-files: fix pathspec display on error", 2011-08-01),
$new_line is assigned once but never used in the script.

Somebody may want to go clean-up the use of various $sq and $SQ
locally defined by giving a unified $SQ in test-lib.sh, by the way.

-- >8 --
Subject: t3005: remove unused variable

Since the beginning of the script, $new_line variable was never used.
Remove it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t3005-ls-files-relative.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/t/t3005-ls-files-relative.sh b/t/t3005-ls-files-relative.sh
index 209b4c7cd8..583e467683 100755
--- a/t/t3005-ls-files-relative.sh
+++ b/t/t3005-ls-files-relative.sh
@@ -7,8 +7,6 @@ This test runs git ls-files with various relative path arguments.
 
 . ./test-lib.sh
 
-new_line='
-'
 sq=\'
 
 test_expect_success 'prepare' '

  reply	other threads:[~2019-09-05 18:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 21:11 [PATCH] t: use LF variable defined in the test harness Junio C Hamano
2019-09-04  0:29 ` Taylor Blau
2019-09-05 18:17   ` Junio C Hamano [this message]
2019-09-05 18:47     ` Jeff King
2019-09-05 19:34       ` Junio C Hamano
2019-09-05 22:10         ` [PATCH] t: use common $SQ variable Denton Liu
2019-09-05 22:25           ` Taylor Blau
2019-09-05 22:27             ` Taylor Blau
2019-09-06  2:04           ` Denton Liu
2019-09-05 18:52     ` [PATCH] t: use LF variable defined in the test harness Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7e6mr4iy.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).