From: Junio C Hamano <gitster@pobox.com>
To: Ed Maste <emaste@freebsd.org>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
git mailing list <git@vger.kernel.org>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
Eric Wong <e@80x24.org>
Subject: Re: [PATCH v3] sparse-checkout: improve OS ls compatibility
Date: Fri, 20 Dec 2019 11:23:18 -0800 [thread overview]
Message-ID: <xmqq7e2qajix.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPyFy2AF+zcriUfZnpbXy+9r7hRpNBUe0agMuan-cE1ryqTipw@mail.gmail.com> (Ed Maste's message of "Fri, 20 Dec 2019 13:34:43 -0500")
Ed Maste <emaste@freebsd.org> writes:
> On Fri, 20 Dec 2019 at 13:21, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> "This is similar to ls" is not all that important, especially if we
>> then need to say how different from "ls" ours is. The log message
>> that describes why we needed to move away from "ls" is a good place
>> to say what aspect of "ls" was unsuitable.
>
> Ok, I'm also happy if it goes in with no comment; the reason I added
> it is I could foresee someone coming along in a few years, thinking
> this is just a strange local implementation of ls, and changing it.
> But, perhaps we can assume that any such person would check the
> history before doing so and the comment is not needed.
>
>> If we _were_ to add an in-code comment, we may want to say something
>> like
>>
>> # Do not replace this with "cd "$1" && ls", as FreeBSD "ls"
>> # enables "-A" when run by root without being told, and ends
>> # up including ".git" etc. in its output.
>>
>> to warn future developers against improving and/or cleaning up.
>
> Indeed, that is more direct, although it's not just FreeBSD ls; this
> came from 4.2BSD and is probably common to most/all non-GNU ls
> implementations. In particular, macOS behaves the same way. (Also, the
> replacement would be even simpler, just "ls $1".)
Good piece of info to include. Final try for the day from me:
# Do not replace this with 'ls "$1"', as "ls" with BSD-lineage
# enables "-A" by default for root and ends up ...
next prev parent reply other threads:[~2019-12-20 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 1:58 [PATCH] sparse-checkout: improve OS ls compatibility Ed Maste
2019-12-19 2:07 ` Derrick Stolee
2019-12-19 2:18 ` Ed Maste
2019-12-19 2:22 ` Derrick Stolee
2019-12-19 2:45 ` Eric Wong
2019-12-19 13:56 ` Derrick Stolee
2019-12-19 16:15 ` Ed Maste
2019-12-19 16:34 ` Derrick Stolee
2019-12-19 18:11 ` Junio C Hamano
2019-12-19 20:56 ` Ed Maste
2019-12-19 22:01 ` Junio C Hamano
2019-12-19 21:45 ` [PATCH v2] " Ed Maste
2019-12-19 22:27 ` Denton Liu
2019-12-20 15:38 ` [PATCH v3] " Ed Maste
2019-12-20 16:05 ` Derrick Stolee
2019-12-20 17:55 ` Junio C Hamano
2019-12-20 17:55 ` Eric Sunshine
2019-12-20 18:15 ` Ed Maste
2019-12-20 18:21 ` Junio C Hamano
2019-12-20 18:34 ` Eric Sunshine
2019-12-20 18:34 ` Ed Maste
2019-12-20 19:23 ` Junio C Hamano [this message]
2019-12-20 19:33 ` Eric Sunshine
2019-12-20 19:41 ` [PATCH v4] " Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7e2qajix.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=emaste@freebsd.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).