From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C8FB71F5AD for ; Fri, 10 Apr 2020 19:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgDJTKP (ORCPT ); Fri, 10 Apr 2020 15:10:15 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:59137 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbgDJTKP (ORCPT ); Fri, 10 Apr 2020 15:10:15 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id AA2486103D; Fri, 10 Apr 2020 15:10:13 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=rQ7FUKnX9sFC 8ltT4Q558cwITdw=; b=c4QXkHWpKiUve5vZDvd9yMJCIHrwET51tNVAvPUgVfXE f5y6YFWfnenEGA7ldTR4nzuQ9JQWqnDhFaIjTFskDjvkstWN6pJkOnKmCYftD3es QjJdiH8HNcQpKdMsEz/TaSt3H6MLSxUPxnNMgkkl5NLlohIFAARVMAPr0ryFDKo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=xWroSv slE2q8jbeZMI8g62ahB+JjWSxwW0G6GWKGoQ4VXFfPCD6NZOKihLzRRCcSrqzopg xYz21Wn5ukIdKHMem2JNoX3VwTsRZ6Tp4AgNcd13WRJeJoMSgvFWXQuNtlapsT3d rhIbaY5TVMuxbkuhOrqtgpBePhU5qLOIa4tFU= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A098F6103C; Fri, 10 Apr 2020 15:10:13 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 23AF86103B; Fri, 10 Apr 2020 15:10:13 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: SZEDER =?utf-8?Q?G=C3=A1bor?= Cc: Johannes Schindelin , Johannes Schindelin via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH 2/5] ci/lib: allow running in GitHub Actions References: <20200403084654.GK2224@szeder.dev> <20200410153131.GM2224@szeder.dev> Date: Fri, 10 Apr 2020 12:10:12 -0700 In-Reply-To: <20200410153131.GM2224@szeder.dev> ("SZEDER =?utf-8?Q?G=C3=A1?= =?utf-8?Q?bor=22's?= message of "Fri, 10 Apr 2020 17:31:31 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: E7A3AA72-7B5E-11EA-9E5A-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org SZEDER G=C3=A1bor writes: >> > CI_OS_NAME=3Dosx. This is head-scratchingly backwards, and I think >> > >> > test "$CI_OS_NAME" =3D macos && CI_OS_NAME=3Dosx >> > >> > would read better. >>=20 >> I can understand where you come from, but your code is not `set -e` sa= fe, > > It works as expected in at least in dash, Bash, BusyBox sh, ksh, > ksh93, mksh/lksh, yash, posh, FreeBSD /bin/sh, NetBSD /bin/sh. Thanks for a clarification. I do not use "set -e" myself (it is not a good idea to rely on it in general), and was wondering if what was said up there was true, as it did not sound like a useful behaviour at all. Not complaining about a non-zero exit before && or || makes it usable ;-)