From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0C9231F55B for ; Tue, 12 May 2020 21:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgELVTa (ORCPT ); Tue, 12 May 2020 17:19:30 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:59115 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgELVT3 (ORCPT ); Tue, 12 May 2020 17:19:29 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 0E85FD3FBB; Tue, 12 May 2020 17:19:28 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=gCpO54ACbHf7uSVrmglLFdG3xb8=; b=CVtmYY mY5zvLuWflhKi1djiplDuaNYw0/mld6++QcKq5Ftj/B50ZGOWVN8ER+Bd+aMewKU r9QYjfP0kKsfzu7mpnzn31raeoUkS9XlNJaCC6+rduVCfsZ/B7D3UFxjt1gsKH5W S0doBn3LQin392eqdIvZk7DazTchCwU+TH2V0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=a80dAR0zm+/Ys6T2vJuADIbZqcHvOBLg uj+e+dyFCE/mWlKhnRQ6C3hVHnU8ijTbt2YP9uey9kYZ404hrxhI0xyUIQZx4318 iVhYKK+h5MtZa+wWMuf/LaTmsIHJ/svtORjtdzNWrVZEPhjgrHpgfdBIPlRjLBTC PaBZigoe+hw= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 06DDDD3FBA; Tue, 12 May 2020 17:19:28 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.99.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 4F94FD3FB8; Tue, 12 May 2020 17:19:25 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Sibi Siddharthan via GitGitGadget" Cc: git@vger.kernel.org, Sibi Siddharthan Subject: Re: [PATCH v2 02/11] cmake: generate the shell/perl/python scripts and templates, translations References: Date: Tue, 12 May 2020 14:19:23 -0700 In-Reply-To: (Sibi Siddharthan via GitGitGadget's message of "Tue, 12 May 2020 16:50:45 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 41842788-9496-11EA-B9D2-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Sibi Siddharthan via GitGitGadget" writes: > From: Sibi Siddharthan > > This patch implements the placeholder substitution to generate, say, > `git-request-pull` from `git-request-pull.sh`. > > The shell/perl/python scripts and template are generated using CMake > (very similar to what sed does). We do not say "This patch does X" or "I do Y in this patch". perhaps. Implement the placeholder substitution to generate scripted Porcelain commands, e.g. git-request-pull out of git-request-pull.sh Generate scripts and templates using CMake, instead of using sed like the build procedure in the Makefile does.