From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Rafael Silva <rafaeloliveira.cs@gmail.com>,
git@vger.kernel.org, dstolee@microsoft.com
Subject: Re: bug found on the new git maintenance builtin command
Date: Mon, 14 Sep 2020 13:55:00 -0700 [thread overview]
Message-ID: <xmqq7dsw2i57.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <0b35829f-a83b-a093-2dc5-0e7d3b42fd15@gmail.com> (Derrick Stolee's message of "Mon, 14 Sep 2020 16:48:35 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 9/14/2020 3:49 PM, Rafael Silva wrote:
>> Hi Everyone,
>>
>> I found a minor bug when testing the new maintenance built-in command that was
>> introduced on 679768e2a1 (maintenance: create basic maintenance runner, 2020-08-25) submitted in [1]
>
> Thank you for identifying the original patch! My gut reaction was that
> this is just in the Part III code which adds subcommands, but that is
> incorrect.
>
>> (gdb) list
>> 1628 int cmd_maintenance(int argc, const char **argv, const char *prefix)
>> 1629 {
>> 1630 if (argc == 2 && !strcmp(argv[1], "-h"))
>> 1631 usage(builtin_maintenance_usage);
>> 1632
>> 1633 fprintf(stdout, "run");
>> 1634 if (!strcmp(argv[1], "run"))
>> 1635 return maintenance_run(argc - 1, argv + 1, prefix);
>> 1636 if (!strcmp(argv[1], "start"))
>> 1637 return maintenance_start();
>> (gdb) print argc
>> $5 = 1
>> (gdb) print argv[1]
>> $6 = 0x0
>>
>> Hope all this information helps with the fixing it
>
> Thank you so much for the report!
>
> The patch below applies to ds/maintenance-part-1, to fix the problem.
> Hopefully it also merges cleanly with the changes in ds/maintenance-part-3,
> but I can deal with that when I submit my next re-roll.
Yuck. I am pretty sure that I did spot this myself during the
review cycle, but apparently it slipped through X-<.
Will apply. Thanks.
prev parent reply other threads:[~2020-09-14 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 19:49 bug found on the new git maintenance builtin command Rafael Silva
2020-09-14 20:48 ` Derrick Stolee
2020-09-14 20:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dsw2i57.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=rafaeloliveira.cs@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).