From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PLING_QUERY,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A51F11F4B4 for ; Thu, 14 Jan 2021 20:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728842AbhANUdV (ORCPT ); Thu, 14 Jan 2021 15:33:21 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:59189 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbhANUdV (ORCPT ); Thu, 14 Jan 2021 15:33:21 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 1BDA3AF7B9; Thu, 14 Jan 2021 15:32:39 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=HoQQoMegRYCpKDhFuO18+KVDPzg=; b=Lx3H1Z in7v3xpOjgRkcBaMjxkW9UQ+cI7NPMfCQUxDgALtocmjcG8D6J5FVgaJtVBD2tDO 6V79Msvxm+96ZzfcHDc2ADDLUuYZpbOUwz1rHCaoFjANGNumy44Y49Ox4V6q5sot i6uMlmiqd9hFOrsMzjSOxlBlzHKKMtxepxIuc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=sG+dNXpzWxZyRO8x0aeExpRblRMMrgRf v3hIGGJkRm5XTkScs3mhSotUY2iGSlFDkWIJGvjfdif7jDUzOp7ZrYM+lSt6GXb7 J1aCJ4nEJNaFGeuy0OKDGQXQwHxWBgXt9kPvQsi0opZ/Z4RtURUCyklIjVVqYks1 9rn7yUvcBAk= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 1301CAF7B7; Thu, 14 Jan 2021 15:32:39 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 84603AF7B6; Thu, 14 Jan 2021 15:32:38 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: Charvi Mendiratta , git , Christian Couder , Phillip Wood , Taylor Blau Subject: Re: How to implement the "amend!" commit ? References: <99b40665-45dd-6c4d-d46a-56c7dbf89568@gmail.com> Date: Thu, 14 Jan 2021 12:32:37 -0800 In-Reply-To: <99b40665-45dd-6c4d-d46a-56c7dbf89568@gmail.com> (Phillip Wood's message of "Thu, 14 Jan 2021 10:39:50 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A49391E6-56A7-11EB-BDF6-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Phillip Wood writes: > This is the only option that is backwards > compatible. `--fixup=:/ ` still works and can be used with the > new syntax as `--fixup=amend::/`. Do you mean both "--fixup=:/" and "--fixup=amend::/" work and do the same thing? If so, that is good. > Note that we intend to allow > accept any prefix of "amend" and "reword" so --fixup=a: would > work. "a" and "r" may happen to be unique but we would not want to be limited to these two forever---future developers are allowed to invent other clever variants. So let's say "accept unique prefix as abbreviation for these operating mode words like 'amend' and 'reword'"