From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0D0161F8C6 for ; Fri, 3 Sep 2021 05:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232661AbhICFGF (ORCPT ); Fri, 3 Sep 2021 01:06:05 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:55195 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232347AbhICFGE (ORCPT ); Fri, 3 Sep 2021 01:06:04 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 2B6CB155480; Fri, 3 Sep 2021 01:05:05 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=qGMZ/kxX394d pw/RAqEntSPmMUhnkyDrXrGrsqbHttQ=; b=UyxOCaYCHgLWffdc3GE+cY3cPuEf 69fBp9wXpilb+2tL2MAD4JbtF01ub/LXv0j2WFoDAoPa1pPIW7YEMqncoFS4tIYh K/klylJuVvhNzZRTgmX9gFtBiJPg8PaG6Ycn+mA8OB3IfofPUg/RpEpPSOdrt04d EPniZU4evz8u3lE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 143AF15547F; Fri, 3 Sep 2021 01:05:05 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.196.172.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 3856B15547D; Fri, 3 Sep 2021 01:05:02 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Jeff King , git@vger.kernel.org, Emily Shaffer , Derrick Stolee Subject: Re: [PATCH v3 2/5] strvec: add a strvec_pushvec() References: <87v93i8svd.fsf@evledraar.gmail.com> Date: Thu, 02 Sep 2021 22:05:00 -0700 In-Reply-To: <87v93i8svd.fsf@evledraar.gmail.com> (=?utf-8?B?IsOGdmFyIEFy?= =?utf-8?B?bmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 03 Sep 2021 01:19:33 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 7EAA20AC-0C74-11EC-B4E6-FA11AF6C5138-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Since the main point of this API is to be a wrapper for what a C main() > would take, shouldn't its prototype mirror its prototype? I.e. we shoul= d > stick to "int" here? That's a fair-enough argument. In other words, we do not mind the upper limit of 2 billion strings, even though we do care that we can have more than 4 billion bytes in any of these strings ;-)