From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS3215 2.6.0.0/16
X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.2
Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])
	by dcvr.yhbt.net (Postfix) with ESMTP id E2A4A1F670
	for <e@yhbt.net>; Mon,  7 Mar 2022 16:48:09 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239278AbiCGQtB (ORCPT <rfc822;e@yhbt.net>);
        Mon, 7 Mar 2022 11:49:01 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39818 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S237206AbiCGQs7 (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 7 Mar 2022 11:48:59 -0500
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F771D311
        for <git@vger.kernel.org>; Mon,  7 Mar 2022 08:48:05 -0800 (PST)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 7045412BEA2;
        Mon,  7 Mar 2022 11:48:01 -0500 (EST)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=QmjSErNHzvzxuNzyQKBrrLNTiO98xLfebLWKal
        0xPSg=; b=XSqcMNi0QbUvl1VmCITEWZ5PuzoQwyXPGVaQJNDy7b3pQgQYJxVjeo
        kOG5xMDo7HcbKeBcn9SMQaGT35oKbe1xmBESP8tjYNoSAaJEj2gVr54K5rl7mMtf
        u61ZLwE+Pt8Bt5BBzj/c09LT9kzM70ROu+FItl/JrrJ+FF/S6zlFs=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 3686912BEA1;
        Mon,  7 Mar 2022 11:48:01 -0500 (EST)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [35.230.65.123])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 2EB2612BEA0;
        Mon,  7 Mar 2022 11:48:00 -0500 (EST)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Derrick Stolee <derrickstolee@github.com>
Cc:     Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
        git@vger.kernel.org, stolee@gmail.com, avarab@gmail.com,
        zhiyou.jx@alibaba-inc.com, jonathantanmy@google.com
Subject: Re: [PATCH 06/11] MyFirstObjectWalk: update recommended usage
References: <pull.1159.git.1645638911.gitgitgadget@gmail.com>
        <355c503157ad02e6106179c2dc7228bdf63a6228.1645638911.git.gitgitgadget@gmail.com>
        <xmqqtucdxs8x.fsf@gitster.g>
        <e163a286-37cb-2568-1d96-0c7b7fba4e5a@github.com>
Date:   Mon, 07 Mar 2022 08:47:59 -0800
In-Reply-To: <e163a286-37cb-2568-1d96-0c7b7fba4e5a@github.com> (Derrick
        Stolee's message of "Mon, 7 Mar 2022 09:05:42 -0500")
Message-ID: <xmqq7d95vhds.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 591DC72C-9E36-11EC-8FDE-CB998F0A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Derrick Stolee <derrickstolee@github.com> writes:

> Definitely room for improvement here. I got hung up on the two uses of
> "it" so here is another attempt:
>
>  If its `filter` member is not `NULL`, then `filter` contains
>  information for how to filter the object list.
>
> What do you think?

Sure.  I won't get hung up on three uses of filter here ;-)

The above reads well.

Thanks.