git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brad Beam <brad.beam@b-rad.info>
Cc: git@vger.kernel.org
Subject: Re: Bug report - ssh signing causes git tag -l malloc failed
Date: Mon, 02 May 2022 13:24:01 -0700	[thread overview]
Message-ID: <xmqq7d73y97i.fsf@gitster.g> (raw)
In-Reply-To: <16668F1B-7670-4136-8AAF-ABAAA802C7D4@b-rad.info> (Brad Beam's message of "Mon, 2 May 2022 14:51:33 -0500")

Brad Beam <brad.beam@b-rad.info> writes:

Thanks for a report.


> What did you do before the bug happened? (Steps to reproduce your issue)
>
> When using ssh signing `git tag -l --format='%(contents:body)' <tag>` returns `fatal: Out of memory, malloc failed (tried to allocate 18446744073709551323 bytes)`

An obvious first follow-up question is if there is any difference in
behaviour if another kind of signing (like PGP) is used.

> What did you expect to happen? (Expected behavior)
>
> The tag to be returned without crashing
>
> What happened instead? (Actual behavior)
>
> git crashed with the above error (`fatal: Out of memory, malloc failed (tried to allocate 18446744073709551323 bytes)`)
>
> What's different between what you expected and what actually happened?
>
> Anything else you want to add:
>
>
> ```
> [14:23:54] (0):~/src/github.com/my/repo
> % git tag -sam v0.0.9 v0.0.9

Here, or before this step, there would probably have been something
to say "No, I do not use the default PGP sign, but I want SSH sign"?

For those who are reading this bug report and mistakenly thought it
is a bug to show a self-recursive tag (like I did during my first
reading of the report), the first v0.0.9 is merely an argument to
the "-m" option, and the second v0.0.9 is the name of the newly
created tag.  We are creating a signed tag with v0.0.9 in the
message that points at HEAD and has "tag v0.0.9" in the header, and
storing the resulting tag at refs/tags/v0.0.9


  reply	other threads:[~2022-05-02 20:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 19:51 Bug report - ssh signing causes git tag -l malloc failed Brad Beam
2022-05-02 20:24 ` Junio C Hamano [this message]
2022-05-03  1:02   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7d73y97i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=brad.beam@b-rad.info \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).