From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 629DD1F54E for ; Mon, 15 Aug 2022 17:33:31 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="eg8LqK7I"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiHORd1 (ORCPT ); Mon, 15 Aug 2022 13:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiHORdZ (ORCPT ); Mon, 15 Aug 2022 13:33:25 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F88C237E4 for ; Mon, 15 Aug 2022 10:33:25 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 5F2ED15669F; Mon, 15 Aug 2022 13:33:24 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=IXmBYCaAoqi+++LI9WKciVFHUn2f9virm19j79 HRaGE=; b=eg8LqK7IEN6KzOAVsbSmPKoc+ymvHSqQhBdWUU592l2PdR1BiMKwZa wpJU25/f7N77e0Sl/tnLMHf1ZHykgNTxX0kwQdrPdbic2XLtLyYfS4qf8fqZdm62 bJI/3vobWzqgAbkgeq1/R01eAvaJZ24lug/+/sekAj0ru13bSn7qM= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 574FF15669E; Mon, 15 Aug 2022 13:33:24 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id BED1715669C; Mon, 15 Aug 2022 13:33:23 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff Hostetler Cc: Eric DeCosta via GitGitGadget , git@vger.kernel.org, Eric DeCosta Subject: Re: [PATCH v4] fsmonitor: option to allow fsmonitor to run against network-mounted repos References: <47e86c2f-ab13-e8e6-8f69-0a79c3f4c343@jeffhostetler.com> Date: Mon, 15 Aug 2022 10:33:22 -0700 In-Reply-To: <47e86c2f-ab13-e8e6-8f69-0a79c3f4c343@jeffhostetler.com> (Jeff Hostetler's message of "Mon, 15 Aug 2022 12:01:50 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5D00787C-1CC0-11ED-8DCF-CB998F0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff Hostetler writes: > On 8/11/22 7:57 PM, Eric DeCosta via GitGitGadget wrote: >> From: Eric DeCosta >> Though perhaps not common, there are uses cases where users have >> large, >> network-mounted repos. Having the ability to run fsmonitor against >> network paths would benefit those users. >> Most modern Samba-based filers have the necessary support to enable >> fsmonitor on network-mounted repos. As a first step towards enabling >> fsmonitor to work against network-mounted repos, introduce a >> configuration option, 'fsmonitor.allowRemote'. Setting this option to >> true will override the default behavior (erroring-out) when a >> network-mounted repo is detected by fsmonitor. > > V4 LGTM. Thanks for your persistence and attention to detail here. Thanks, both. Queued.