From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C71511F403 for ; Mon, 3 Oct 2022 18:05:46 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Fy8HFdGj"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbiJCSFo (ORCPT ); Mon, 3 Oct 2022 14:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbiJCSFM (ORCPT ); Mon, 3 Oct 2022 14:05:12 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A88C322BE7 for ; Mon, 3 Oct 2022 11:05:09 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id c3so5986535pfb.12 for ; Mon, 03 Oct 2022 11:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=8tkjxkDmA7cP9dn/kM+RcUzB3Hna5zZaOuiyKa1jTzs=; b=Fy8HFdGj8hworQAcgGnFSuBnfjlqL5rBOrHVGfu6/ZSGlgkX9eJYscu6cEis6b+03X pwNwJAZVN98MlRKSFhJgCAhZD/RadDYMAu/ri48teUwtNl6XdDxQXb5EX92lADMU586F g/aXWf8KK4nri88bWTnM5HAn1abrkVhoUJdjqtRnumlUH7OHEKZtkRB9cCkth5u645TH gAqsYtB2R7QnJob/B+vFW2EfCTDUUt0E1WYq00XhHfHjAgrj20Bg2d0861SEnHwOcicf WRqS1CJDxqbLWyPvuvlpIiBFEyd4AMj84WYLpg8hILiMJw5/pDMHfYUoZXBS1SYiX9zB 7QTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8tkjxkDmA7cP9dn/kM+RcUzB3Hna5zZaOuiyKa1jTzs=; b=qdhdzbzZZB25y5eOq743rtbCdW/h2k3dEWWMkfGCJAHaerFFXiQSW7SZFBsgdNPSi3 dHzmjUYHZUrGWfGDZvqfbCMcrZYcbgZNN9/YADrGl8a63n+P7wYtlG9trgJ7FzwImPA+ 52x+7+UFuXwAma/sBtfxJmFrLhiM8nlXx/Y9r+kNF4kP9n0uXoHQhKmgyT/X9loxtMKj hFM9LvBk+APkcDMWY0KK+0GqtvAvRd1Nc7sDePMqvDqFeOvbAz4UZeflwkM0K2ceUuWl OHqHzOivAP82mRQU3wZpASgZXpNOmxALK+6ycgR5qShj3EnleVz/R+hdVnIIM2Aop8qS QYzA== X-Gm-Message-State: ACrzQf1hK7jbtPuulwF4/LyPmvX/ju4U3PhJITBkmRsPJa5sJlfpekFO ubu9yT2fdxxPbKU9IA7ins8= X-Google-Smtp-Source: AMsMyM4vSJmUm+I053XPcTJ0kzkhHQgJ07639vf/uc8FxAgqvww1k/ku2Bmd8SDljlyYyZI1jqYREQ== X-Received: by 2002:a65:6954:0:b0:445:fdb8:738e with SMTP id w20-20020a656954000000b00445fdb8738emr10671840pgq.520.1664820308577; Mon, 03 Oct 2022 11:05:08 -0700 (PDT) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id ik21-20020a170902ab1500b00176be23bbb3sm7436632plb.172.2022.10.03.11.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 11:05:07 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: Jeff King Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , "Michael V. Scovetta" , Phillip Wood , git@vger.kernel.org Subject: Re: [PATCH] sequencer: detect author name errors in read_author_script() References: <221003.86k05htf84.gmgdl@evledraar.gmail.com> Date: Mon, 03 Oct 2022 11:05:05 -0700 In-Reply-To: (Jeff King's message of "Mon, 3 Oct 2022 13:39:31 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > On Mon, Oct 03, 2022 at 01:27:37PM -0400, Jeff King wrote: > >> -check_broken_author 'unknown key in author-script' ' >> +test_expect_success 'unknown key in author-script' ' >> + create_conflict && >> + >> echo "GIT_AUTHOR_BOGUS=${SQ}whatever${SQ}" \ >> - >>.git/rebase-merge/author-script' >> + >>.git/rebase-merge/author-script && >> >> + check_resolve_fails >> +' >> >> test_done >> >> That makes the boilerplate shorter in the "-v" output but focuses on the >> actual modification that breaks the author-script. > > Note that we do still keep the ${SQ} bits here. They're necessary for > the same reason: before and after a snippet is being passed through a > variable. Whereas in yours we'd use stdin. I _do_ like that approach in > general, but it is unlike the rest of the test suite. Maybe it's worth > resurrecting: > > https://lore.kernel.org/git/YHDUg6ZR5vu93kGm@coredump.intra.peff.net/ > > ? Yeah, it is indeed quite tempting.